From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: move debug macros to common location
Date: Tue, 04 Sep 2012 17:02:15 -0500 [thread overview]
Message-ID: <50467A67.3010300@gmail.com> (raw)
In-Reply-To: <20120901085340.GA20497@lunn.ch>
On 09/01/2012 03:53 AM, Andrew Lunn wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Based on suggestion by Russell King, create a common location for debug
>> macros and select the included debug macro file using config option.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> ---
>> arch/arm/Kconfig.debug | 5 +++
>> arch/arm/include/debug/icedcc.S | 90 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/kernel/debug.S | 87 ++-----------------------------------
>> arch/arm/kernel/head.S | 4 +-
>> 4 files changed, 100 insertions(+), 86 deletions(-)
>> create mode 100644 arch/arm/include/debug/icedcc.S
>
> Hi Rob
>
> What about arch/arm/include/asm/hardware/debug-8250.S and
> arch/arm/include/asm/hardware/debug-pl01x.S?
>
> Might be nice to have these two also in arch/arm/include/debug/, or
> follow the naming convention set by these two and have
> arch/arm/include/asm/hardware/debug-icedcc.S?
I agree we should move those, but would rather do it after moving all
the debug-macro.S files into include/debug. As I mentioned in the
multi-platform thread, I think there are further improvements we can do
and eliminate many of the debug-macro.S files.
Rob
next prev parent reply other threads:[~2012-09-04 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 8:53 [PATCH 1/3] ARM: move debug macros to common location Andrew Lunn
2012-09-04 22:02 ` Rob Herring [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-31 18:29 Rob Herring
2012-09-01 18:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50467A67.3010300@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.