From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs Date: Wed, 05 Sep 2012 09:41:06 +0800 Message-ID: <5046ADB2.9020703@cn.fujitsu.com> References: <1346148027-24468-1-git-send-email-wency@cn.fujitsu.com> <1346148027-24468-9-git-send-email-wency@cn.fujitsu.com> <20120831140623.8d13bd2c.akpm@linux-foundation.org> <5044454E.7070909@cn.fujitsu.com> <20120904161634.f1f9f693.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:55962 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751980Ab2IEBqX (ORCPT ); Tue, 4 Sep 2012 21:46:23 -0400 In-Reply-To: <20120904161634.f1f9f693.akpm@linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andrew Morton Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Christoph Lameter At 09/05/2012 07:16 AM, Andrew Morton Wrote: > On Mon, 03 Sep 2012 13:51:10 +0800 > Wen Congyang wrote: > >>>> +static void release_firmware_map_entry(struct kobject *kobj) >>>> +{ >>>> + struct firmware_map_entry *entry = to_memmap_entry(kobj); >>>> + struct page *page; >>>> + >>>> + page = virt_to_page(entry); >>>> + if (PageSlab(page) || PageCompound(page)) >>> >>> That PageCompound() test looks rather odd. Why is this done? >> >> Liu Jiang and Christoph Lameter discussed how to find slab page >> in this mail: >> https://lkml.org/lkml/2012/7/6/333. > > Well, please add a code comment to release_firmware_map_entry() which > fully explains these things. > > I see that Christoph and I agree: "It would be cleaner if memory > hotplug had an indicator which allocation mechanism was used and would > use the corresponding free action". You didn't respond to this > suggestion when he made it, nor when I made it. What are your thoughts > on this? Hmm, I think it is better to use an indicator which allocation mechanism was used. I will do it in the next version. Thanks Wen Congyang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Date: Wed, 05 Sep 2012 01:41:06 +0000 Subject: Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs Message-Id: <5046ADB2.9020703@cn.fujitsu.com> List-Id: References: <1346148027-24468-1-git-send-email-wency@cn.fujitsu.com> <1346148027-24468-9-git-send-email-wency@cn.fujitsu.com> <20120831140623.8d13bd2c.akpm@linux-foundation.org> <5044454E.7070909@cn.fujitsu.com> <20120904161634.f1f9f693.akpm@linux-foundation.org> In-Reply-To: <20120904161634.f1f9f693.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Christoph Lameter At 09/05/2012 07:16 AM, Andrew Morton Wrote: > On Mon, 03 Sep 2012 13:51:10 +0800 > Wen Congyang wrote: > >>>> +static void release_firmware_map_entry(struct kobject *kobj) >>>> +{ >>>> + struct firmware_map_entry *entry = to_memmap_entry(kobj); >>>> + struct page *page; >>>> + >>>> + page = virt_to_page(entry); >>>> + if (PageSlab(page) || PageCompound(page)) >>> >>> That PageCompound() test looks rather odd. Why is this done? >> >> Liu Jiang and Christoph Lameter discussed how to find slab page >> in this mail: >> https://lkml.org/lkml/2012/7/6/333. > > Well, please add a code comment to release_firmware_map_entry() which > fully explains these things. > > I see that Christoph and I agree: "It would be cleaner if memory > hotplug had an indicator which allocation mechanism was used and would > use the corresponding free action". You didn't respond to this > suggestion when he made it, nor when I made it. What are your thoughts > on this? Hmm, I think it is better to use an indicator which allocation mechanism was used. I will do it in the next version. Thanks Wen Congyang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id EAC6F2C008A for ; Wed, 5 Sep 2012 11:46:23 +1000 (EST) Message-ID: <5046ADB2.9020703@cn.fujitsu.com> Date: Wed, 05 Sep 2012 09:41:06 +0800 From: Wen Congyang MIME-Version: 1.0 To: Andrew Morton Subject: Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs References: <1346148027-24468-1-git-send-email-wency@cn.fujitsu.com> <1346148027-24468-9-git-send-email-wency@cn.fujitsu.com> <20120831140623.8d13bd2c.akpm@linux-foundation.org> <5044454E.7070909@cn.fujitsu.com> <20120904161634.f1f9f693.akpm@linux-foundation.org> In-Reply-To: <20120904161634.f1f9f693.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, len.brown@intel.com, linux-acpi@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, cmetcalf@tilera.com, linux-mm@kvack.org, isimatu.yasuaki@jp.fujitsu.com, paulus@samba.org, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, sparclinux@vger.kernel.org, Christoph Lameter , cl@linux.com, linuxppc-dev@lists.ozlabs.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , At 09/05/2012 07:16 AM, Andrew Morton Wrote: > On Mon, 03 Sep 2012 13:51:10 +0800 > Wen Congyang wrote: > >>>> +static void release_firmware_map_entry(struct kobject *kobj) >>>> +{ >>>> + struct firmware_map_entry *entry = to_memmap_entry(kobj); >>>> + struct page *page; >>>> + >>>> + page = virt_to_page(entry); >>>> + if (PageSlab(page) || PageCompound(page)) >>> >>> That PageCompound() test looks rather odd. Why is this done? >> >> Liu Jiang and Christoph Lameter discussed how to find slab page >> in this mail: >> https://lkml.org/lkml/2012/7/6/333. > > Well, please add a code comment to release_firmware_map_entry() which > fully explains these things. > > I see that Christoph and I agree: "It would be cleaner if memory > hotplug had an indicator which allocation mechanism was used and would > use the corresponding free action". You didn't respond to this > suggestion when he made it, nor when I made it. What are your thoughts > on this? Hmm, I think it is better to use an indicator which allocation mechanism was used. I will do it in the next version. Thanks Wen Congyang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx170.postini.com [74.125.245.170]) by kanga.kvack.org (Postfix) with SMTP id 9AD346B005D for ; Tue, 4 Sep 2012 21:46:23 -0400 (EDT) Message-ID: <5046ADB2.9020703@cn.fujitsu.com> Date: Wed, 05 Sep 2012 09:41:06 +0800 From: Wen Congyang MIME-Version: 1.0 Subject: Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs References: <1346148027-24468-1-git-send-email-wency@cn.fujitsu.com> <1346148027-24468-9-git-send-email-wency@cn.fujitsu.com> <20120831140623.8d13bd2c.akpm@linux-foundation.org> <5044454E.7070909@cn.fujitsu.com> <20120904161634.f1f9f693.akpm@linux-foundation.org> In-Reply-To: <20120904161634.f1f9f693.akpm@linux-foundation.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Christoph Lameter At 09/05/2012 07:16 AM, Andrew Morton Wrote: > On Mon, 03 Sep 2012 13:51:10 +0800 > Wen Congyang wrote: > >>>> +static void release_firmware_map_entry(struct kobject *kobj) >>>> +{ >>>> + struct firmware_map_entry *entry = to_memmap_entry(kobj); >>>> + struct page *page; >>>> + >>>> + page = virt_to_page(entry); >>>> + if (PageSlab(page) || PageCompound(page)) >>> >>> That PageCompound() test looks rather odd. Why is this done? >> >> Liu Jiang and Christoph Lameter discussed how to find slab page >> in this mail: >> https://lkml.org/lkml/2012/7/6/333. > > Well, please add a code comment to release_firmware_map_entry() which > fully explains these things. > > I see that Christoph and I agree: "It would be cleaner if memory > hotplug had an indicator which allocation mechanism was used and would > use the corresponding free action". You didn't respond to this > suggestion when he made it, nor when I made it. What are your thoughts > on this? Hmm, I think it is better to use an indicator which allocation mechanism was used. I will do it in the next version. Thanks Wen Congyang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org