From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Lpq-0006EP-52 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9Lpp-0006pe-5d for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:04:26 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Lpo-0006pY-VI for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:04:25 -0400 Message-ID: <5047B046.6040503@weilnetz.de> Date: Wed, 05 Sep 2012 22:04:22 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 05.09.2012 21:18, schrieb Anthony Liguori: > This is minimalistic and just contains the basic widget infrastructure. The GUI > consists of a menu and a GtkNotebook. To start with, the notebook has its tabs > hidden which provides a UI that looks very similar to SDL with the exception of > the menu bar. > > The menu bar allows a user to toggle the visibility of the tabs. Cairo is used > for rendering. > > I used gtk-vnc as a reference. gtk-vnc solves the same basic problems as QEMU > since it was originally written as a remote display for QEMU. So for the most > part, the approach to rendering and keyboard handling should be pretty solid for > GTK. > > Signed-off-by: Anthony Liguori > --- > v1 -> v2 > - add gtk-vnc license > - fix key propagation > --- > Makefile | 2 + > configure | 25 +++- > console.h | 4 + > sysemu.h | 1 + > ui/Makefile.objs | 1 + > ui/gtk.c | 572 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 604 insertions(+), 1 deletions(-) > create mode 100644 ui/gtk.c > Hi Anthony, I tested the previous version of your series and noticed that the menu accelerators (especially for file/quit) which are still part of this new patch are a bad idea. Just run a system emulation, start some GUI program in the emulation and press Ctrl-Q: you won't terminate the GUI program, but terminate QEMU! Cheers, Stefan W.