Re: [PATCH 1/3] phonesim: Extend conformance menu with Setup Call items

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3225 bytes --]

Hi Philippe,

On 09/05/2012 12:21 PM, Philippe Nunes wrote:
> ---
>   src/conformancesimapplication.cpp |  247 +++++++++++++++++++++++++++++++++++++
>   src/simapplication.h              |    2 +
>   2 files changed, 249 insertions(+)

<snip>

>
> +        case SetupCall_Max_Dialing_Number:
> +          {
> +              cmd.setType( QSimCommand::SetupCall );
> +              cmd.setDestinationDevice( QSimCommand::Network );
> +              cmd.setNumber( "+01234567890123456789012345678901" );
> +              cmd.setDisposition( QSimCommand::Disconnect );
> +              command( cmd, this, SLOT(sendSetupCallMenu()) );
> +          }
> +          break;

Can we actually fix the inconsistent indentation here?

> +
> +        case SetupCall_Two_AID:
> +         {
> +             cmd.setType( QSimCommand::SetupCall );
> +             cmd.setDestinationDevice( QSimCommand::Network );
> +             cmd.setText( "CONFIRMATION" );
> +             cmd.setOtherText( "CALL" );
> +             cmd.setNumber( "+012340123456p1p2" );
> +             cmd.setDisposition( QSimCommand::Disconnect );
> +             command( cmd, this, SLOT(sendSetupCallMenu()) );
> +         }
> +         break;

And here?

> +
> +        case SetupCall_Basic_icon:
> +        {
> +            cmd.setType( QSimCommand::SetupCall );
> +            cmd.setDestinationDevice( QSimCommand::Network );
> +            cmd.setText( "Set up call Icon 3.1.1" );
> +            cmd.setNumber( "+012340123456p1p2" );
> +            cmd.setIconId( 1 );
> +            cmd.setIconSelfExplanatory( false );
> +            cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> +            command( cmd, this, SLOT(sendSetupCallMenu()) );
> +        }
> +        break;
> +
> +        case SetupCall_Self_basic_icon:
> +         {
> +             cmd.setType( QSimCommand::SetupCall );
> +             cmd.setDestinationDevice( QSimCommand::Network );
> +             cmd.setText( "Set up call Icon 3.2.1" );
> +             cmd.setNumber( "+012340123456p1p2" );
> +             cmd.setIconId( 1 );
> +             cmd.setIconSelfExplanatory( true );
> +             cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> +             command( cmd, this, SLOT(sendSetupCallMenu()) );
> +         }
> +         break;

And here

> +
> +        case SetupCall_Basic_icon_during_call:
> +         {
> +             cmd.setType( QSimCommand::SetupCall );
> +             cmd.setDestinationDevice( QSimCommand::Network );
> +             cmd.setText( "Set up call Icon 3.4.1" );
> +             cmd.setNumber( "+012340123456p1p2" );
> +             cmd.setIconId( 1 );
> +             cmd.setIconSelfExplanatory( true );
> +             cmd.setOtherText( "Set up call Icon 3.4.2" );
> +             cmd.setOtherIconId( 1 );
> +             cmd.setOtherIconSelfExplanatory( true );
> +             cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> +             command( cmd, this, SLOT(sendSetupCallMenu()) );
> +         }
> +         break;

And here.

> +
> +        default:
> +            endSession();
> +        break;
> +    }
> +}

Regards,
-Denis