From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?6rmA7Iq57Jqw?= <sw0312.kim@samsung.com>
Subject: Re: [PATCH] drm/exynos: fix double call of
 drm_prime_(init/destroy)_file_private
Date: Thu, 06 Sep 2012 11:15:11 +0900
Message-ID: <5048072F.3020602@samsung.com>
References: <1346881623-388-1-git-send-email-msb@chromium.org>
Reply-To: sw0312.kim@samsung.com
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-reply-to: <1346881623-388-1-git-send-email-msb@chromium.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Inki Dae <inki.dae@samsung.com>, linux-kernel@vger.kernel.org, =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= <marcheu@chromium.org>, Pawel Osciak <posciak@google.com>, Joonyoung Shim <jy0922.shim@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Mandeep,

On 2012=EB=85=84 09=EC=9B=94 06=EC=9D=BC 06:47, Mandeep Singh Baines wr=
ote:
> The double invocations are incorrect but seem to be safe so I don't
> think this will fix any bugs.
>=20
> Before:
>=20
> [    7.639366] drm_prime_init_file ee3675d0
> [    7.639377] drm_prime_init_file ee3675d0
> [    7.639507] drm_prime_destroy_file ee3675d0
> [    7.639518] drm_prime_destroy_file ee3675d0
> [    7.639802] drm_prime_init_file ee372390
> [    7.639810] drm_prime_init_file ee372390
> [    8.473316] drm_prime_init_file ee356390
> [    8.473331] drm_prime_init_file ee356390
>=20
> After:
>=20
> [    6.363842] drm_prime_init_file edc2e5d0
> [    6.363994] drm_prime_destroy_file edc2e5d0
> [    6.364260] drm_prime_init_file edc2e750
> [    8.004837] drm_prime_init_file ee36ded0
>=20

You are right. prime file_priv is handled by drm_fops.c, so it can be
removed from exynos drm.

Thanks for your patch.

> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> CC: St=C3=A9phane Marchesin <marcheu@chromium.org>
> CC: Pawel Osciak <posciak@google.com>
> CC: Inki Dae <inki.dae@samsung.com>
> CC: Joonyoung Shim <jy0922.shim@samsung.com>
> CC: Seung-Woo Kim <sw0312.kim@samsung.com>
> CC: Kyungmin Park <kyungmin.park@samsung.com>
> CC: David Airlie <airlied@linux.ie>
> CC: dri-devel@lists.freedesktop.org

Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>

> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/dr=
m/exynos/exynos_drm_drv.c
> index ebacec6..a27b8ff 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -160,7 +160,6 @@ static int exynos_drm_open(struct drm_device *dev=
, struct drm_file *file)
>  	if (!file_priv)
>  		return -ENOMEM;
> =20
> -	drm_prime_init_file_private(&file->prime);
>  	file->driver_priv =3D file_priv;
> =20
>  	return exynos_drm_subdrv_open(dev, file);
> @@ -184,7 +183,6 @@ static void exynos_drm_preclose(struct drm_device=
 *dev,
>  			e->base.destroy(&e->base);
>  		}
>  	}
> -	drm_prime_destroy_file_private(&file->prime);
>  	spin_unlock_irqrestore(&dev->event_lock, flags);
> =20
>  	exynos_drm_subdrv_close(dev, file);
>=20

--=20
Seung-Woo Kim
Samsung Software R&D Center
--