From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [SeaBIOS] [PATCH v3] add acpi pmtimer support Date: Thu, 06 Sep 2012 08:03:00 +0200 Message-ID: <50483C94.2050101@redhat.com> References: <1346822895-19196-1-git-send-email-kraxel@redhat.com> <20120905232823.GA11847@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: seabios@seabios.org, kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301Ab2IFGDe (ORCPT ); Thu, 6 Sep 2012 02:03:34 -0400 In-Reply-To: <20120905232823.GA11847@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 09/06/12 01:28, Kevin O'Connor wrote: > On Wed, Sep 05, 2012 at 07:28:15AM +0200, Gerd Hoffmann wrote: >> This patch makes seabios use the acpi pmtimer instead of tsc for >> timekeeping. The pmtimer has a fixed frequency and doesn't need >> calibration, thus it doesn't suffer from calibration errors due to a >> loaded host machine. >> >> [ v3: mask port ioport read ] > [...] >> +static u64 pmtimer_get(void) >> +{ >> + u16 ioport = GET_GLOBAL(pmtimer_ioport); >> + u32 wraps = GET_LOW(pmtimer_wraps); >> + u32 pmtimer = inl(ioport); > > Mask still missing? Oops. Change was still uncommitted in my work tree, /me just forgot 'git add' I guess. New version on the way. cheers, Gerd