From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment Date: Thu, 06 Sep 2012 10:44:15 +0200 Message-ID: <5048625F.2060706@siemens.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , =?ISO-8859-15?Q?Andreas_F=E4rber?= , Peter Maydell To: Avi Kivity , Marcelo Tosatti Return-path: Received: from goliath.siemens.de ([192.35.17.28]:17419 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755144Ab2IFIo3 (ORCPT ); Thu, 6 Sep 2012 04:44:29 -0400 In-Reply-To: <503FB128.4070709@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-08-30 20:30, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to remain relevant for another couple of years until kernels > without full-features and performance-wise equivalent VFIO support are > obsolete. > > A refactoring to-do that should be done in-tree is to model MSI and > MSI-X support via the generic PCI layer, similar to what VFIO is already > doing for MSI-X. This should improve the correctness and clean up the > code from duplicate logic. > > Signed-off-by: Jan Kiszka > --- > > Changes in v3: > - addressed comment by Peter (changed device name to kvm-pci-assign + > alias) > - addressed (most) comments by Michael > - fixed INT pin regression Does someone _disagree_ that there are no open (and reasonably solvable) issues and that this can now be merged through uq/master? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XhL-0002G3-OU for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:44:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9XhH-0002cq-O4 for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:44:27 -0400 Received: from goliath.siemens.de ([192.35.17.28]:16568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XhH-0002cf-FV for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:44:23 -0400 Message-ID: <5048625F.2060706@siemens.com> Date: Thu, 06 Sep 2012 10:44:15 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> In-Reply-To: <503FB128.4070709@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Marcelo Tosatti Cc: Peter Maydell , kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , =?ISO-8859-15?Q?Andreas_F=E4rber?= On 2012-08-30 20:30, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to remain relevant for another couple of years until kernels > without full-features and performance-wise equivalent VFIO support are > obsolete. > > A refactoring to-do that should be done in-tree is to model MSI and > MSI-X support via the generic PCI layer, similar to what VFIO is already > doing for MSI-X. This should improve the correctness and clean up the > code from duplicate logic. > > Signed-off-by: Jan Kiszka > --- > > Changes in v3: > - addressed comment by Peter (changed device name to kvm-pci-assign + > alias) > - addressed (most) comments by Michael > - fixed INT pin regression Does someone _disagree_ that there are no open (and reasonably solvable) issues and that this can now be merged through uq/master? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux