Re: [Qemu-devel] [PATCH] usb: Fix host-side endian bugs in hcd-ehci

[Gerd Hoffmann <kraxel@redhat.com>]

On 08/22/12 05:04, David Gibson wrote:
> The EHCI device model is horribly broken for big-endian hosts.  It uses a
> union of 'mmio' a byte array which is as-is as the device's MMIO space
> with the various internal registers.  The IO routines assume that mmio is
> laid out in little-endian order, but everything else in the code accesses
> the register variables directly assuming (host) native endian.
> 
> This fix is fairly ugly - a nicer approach would involve converting
> hcd-ehci to use the new-style memory region .read and .write functions -
> but it's the most minimal fix I can see to apply for the qemu 1.2 release.

Oops.  This one slipped through.  Just found it -- to late for 1.2 --
while wading through my inbox looking for unprocessed stuff.

Doing the real thing instead (i.e. convert memory regions) doesn't look
that horrible though, I think we can put that into stable-1.2.  I'll
send out the patch in a few moments.

cheers,
  Gerd