From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH v6] uartclk value from serial_core exposed to sysfs Date: Thu, 06 Sep 2012 19:54:39 +0200 Message-ID: <5048E35F.5020304@suse.cz> References: <1344929718-22736-1-git-send-email-tmshlvck@gmail.com> <1346894238-12870-1-git-send-email-tmshlvck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:37751 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729Ab2IFRyn (ORCPT ); Thu, 6 Sep 2012 13:54:43 -0400 In-Reply-To: <1346894238-12870-1-git-send-email-tmshlvck@gmail.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Tomas Hlavacek Cc: gregkh@linuxfoundation.org, alan@linux.intel.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, marek.vasut@gmail.com On 09/06/2012 03:17 AM, Tomas Hlavacek wrote: > @@ -2362,8 +2392,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) > * Register the port whether it's detected or not. This allows > * setserial to be used to alter this ports parameters. > */ > - tty_dev = tty_port_register_device(port, drv->tty_driver, uport->line, > - uport->dev); > + tty_dev = tty_register_device_attr(drv->tty_driver, uport->line, > + uport->dev, port, tty_dev_attr_groups); This makes me believe you have not tested the change at all? -- js suse labs