From: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Antonio Quartulli <ordex@autistici.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 1/2] mac80211: export ieee80211_send_deauth_disassoc for usage outside of mlme.c
Date: Fri, 07 Sep 2012 11:50:18 +0200 [thread overview]
Message-ID: <5049C35A.1050601@lri.fr> (raw)
In-Reply-To: <1347006332.4256.9.camel@jlt4.sipsolutions.net>
On 07/09/2012 10:25, Johannes Berg wrote:
> On Thu, 2012-09-06 at 19:07 +0200, Antonio Quartulli wrote:
>
>> - if (!(ifmgd->flags & IEEE80211_STA_MFP_ENABLED))
>> - IEEE80211_SKB_CB(skb)->flags |=
>> - IEEE80211_TX_INTFL_DONT_ENCRYPT;
>
>
>> + if (sdata->vif.type == NL80211_IFTYPE_STATION &&
>> + !(sdata->u.mgd.flags & IEEE80211_STA_MFP_ENABLED))
>> + IEEE80211_SKB_CB(skb)->flags |=
>> + IEEE80211_TX_INTFL_DONT_ENCRYPT;
>
> It would seem that this should be
>
> if (sdata->vif.type != NL80211_IFTYPE_STATION ||
> !(flags & MFP_ENABLED))
>
> ?
Or just never set TX_INTFL_DONT_ENCRYPT at all and rely on
ieee80211_tx_h_select_key() to do the right thing ?
next prev parent reply other threads:[~2012-09-07 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 17:07 [PATCHv2 1/2] mac80211: export ieee80211_send_deauth_disassoc for usage outside of mlme.c Antonio Quartulli
2012-09-06 17:07 ` [PATCHv2 2/2] mac80211: reply to AUTH frame with a DEAUTH if sta allocation fails Antonio Quartulli
2012-09-07 8:25 ` [PATCHv2 1/2] mac80211: export ieee80211_send_deauth_disassoc for usage outside of mlme.c Johannes Berg
2012-09-07 9:50 ` Nicolas Cavallari [this message]
2012-09-07 11:18 ` Johannes Berg
2012-09-07 11:21 ` Antonio Quartulli
2012-09-07 12:01 ` Nicolas Cavallari
2012-09-07 12:05 ` Johannes Berg
2012-09-07 12:18 ` Nicolas Cavallari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049C35A.1050601@lri.fr \
--to=nicolas.cavallari@lri.fr \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.