Re: [PATCH net-next] ipv4/route: arg delay is useless in rt_cache_flush()

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 07/09/2012 12:29, Eric Dumazet a écrit :
> On Fri, 2012-09-07 at 11:31 +0200, Nicolas Dichtel wrote:
>> Since route cache deletion (89aef8921bfbac22f), delay is no
>> more used. Remove it.
>>
> ...
>
>>   #ifdef CONFIG_SYSCTL
>> @@ -2354,16 +2350,12 @@ static int ipv4_sysctl_rtcache_flush(ctl_table *__ctl, int write,
>>   					size_t *lenp, loff_t *ppos)
>>   {
>>   	if (write) {
>> -		int flush_delay;
>>   		ctl_table ctl;
>>   		struct net *net;
>>
>>   		memcpy(&ctl, __ctl, sizeof(ctl));
>> -		ctl.data = &flush_delay;
>> -		proc_dointvec(&ctl, write, buffer, lenp, ppos);
>> -
>>   		net = (struct net *)__ctl->extra1;
>> -		rt_cache_flush(net, flush_delay);
>> +		rt_cache_flush(net);
>>   		return 0;
>>   	}
>>
>
> Why do you keep ctl then ?
>
> 	if (write) {
> 		rt_cache_flush((struct net *)__ctl->extra1);
> 		return 0;
> 	}
>
>
Right, there is no reason.


Regards,
Nicolas