From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] kexec/noreboot: Don't kexec_crash() if noreboot has been requested. Date: Fri, 7 Sep 2012 14:28:30 +0100 Message-ID: <5049F67E.3080709@citrix.com> References: <5049F10F.5010801@citrix.com> <504A0FDA0200007800099D10@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <504A0FDA0200007800099D10@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Keir (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 07/09/12 14:16, Jan Beulich wrote: >>>> On 07.09.12 at 15:05, Andrew Cooper wrote: >> This issue came up when debugging pcpu linked list corruption (patches >> for that issue to follow). > Hmm, that's a matter of taste of course. Nor is running kdump > really a (direct) reboot action. Both ways have their reasoning > imo, so I'm not sure whether keeping things as is or applying the > patch is the better thing. > > Jan Hmm yes - I guess its not as clean cut as I thought, but I would still argue that this patch is the lest surprising alternative. One tweak I am thinking of working on soon is a "pause-on-reboot" feature which is a bit like noreboot, but will accept a passphrase and continue with the reboot, so you can 'pause', see the dying panic then reboot without needing to invoke the server power management. (This may have been as a result of being given details for the wrong server power management interface IP address when debugging a server in a data center 7 time zones away, and getting rather confused when it didn't make any attempt to reboot. I imagine someone else might get equally irate if their server was rebooting without warning.) ~Andrew > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com