From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 0/5] rbd: code cleanup
Date: Fri, 07 Sep 2012 08:34:45 -0500 [thread overview]
Message-ID: <5049F7F5.1070609@inktank.com> (raw)
This second series consists of fairly simple bits of code cleanup.
It is available as branch "wip-rbd-review-2" on the ceph-client git
repository, and is based on the branch "wip-rbd-review-1".
https://github.com/ceph/ceph-client/tree/wip-rbd-review-2
-Alex
[PATCH 1/5] a0f6877 rbd: define rbd_assert()
This defines a new macro rbd_assert() that's used to express
invariant properties assumed by the code. If the property does
not hold it triggers a BUG(). Everywhere that BUG_ON() had been
used is replaced with an equivalent call to rbd_assert().
[PATCH 2/5] a8aac82 rbd: rename rbd_id_get()
[PATCH 3/5] 12c5aa2 rbd: rename __rbd_init_snaps_header()
These rename some symbols to align better with how their used.
[PATCH 4/5] e8cb272 rbd: kill rbd_dev->q
[PATCH 5/5] 1557afc rbd: kill rbd_image_header->total_snaps
These eliminate two struct fields, one which is unused and the
other which is redundant and therefore not necessary.
next reply other threads:[~2012-09-07 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 13:34 Alex Elder [this message]
2012-09-07 13:39 ` [PATCH 1/5] rbd: define rbd_assert() Alex Elder
2012-09-07 18:13 ` Josh Durgin
2012-09-07 13:39 ` [PATCH 2/5] rbd: rename rbd_id_get() Alex Elder
2012-09-07 18:14 ` Josh Durgin
2012-09-07 13:39 ` [PATCH 3/5] rbd: rename __rbd_init_snaps_header() Alex Elder
2012-09-07 18:16 ` Josh Durgin
2012-09-07 13:39 ` [PATCH 4/5] rbd: kill rbd_dev->q Alex Elder
2012-09-07 18:16 ` Josh Durgin
2012-09-07 13:39 ` [PATCH 5/5] rbd: kill rbd_image_header->total_snaps Alex Elder
2012-09-07 18:17 ` Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049F7F5.1070609@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.