From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9zJz-00047k-Vm for qemu-devel@nongnu.org; Fri, 07 Sep 2012 10:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9zJr-00077O-Oj for qemu-devel@nongnu.org; Fri, 07 Sep 2012 10:14:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49446 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9zJr-000765-IQ for qemu-devel@nongnu.org; Fri, 07 Sep 2012 10:14:03 -0400 Message-ID: <504A0124.1070509@suse.de> Date: Fri, 07 Sep 2012 16:13:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1347026144-15098-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1347026144-15098-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Anthony Liguori , patches@linaro.org, qemu-devel@nongnu.org, Markus Armbruster Am 07.09.2012 15:55, schrieb Peter Maydell: > Reject attempts to add a property to an object if one of > that name already exists. This is always a bug in the caller; > this is merely diagnosing it gracefully rather than behaving > oddly later. >=20 > Signed-off-by: Peter Maydell Looks fine to me, Reviewed-by: Andreas F=E4rber /-F --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg