From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9zw4-0000bB-9e for qemu-devel@nongnu.org; Fri, 07 Sep 2012 10:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9zvy-0005yw-HP for qemu-devel@nongnu.org; Fri, 07 Sep 2012 10:53:32 -0400 Message-ID: <504A0A60.8090507@web.de> Date: Fri, 07 Sep 2012 16:53:20 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <50492BC5.4090107@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig492033FCE4E6C7A59EABD26A" Subject: Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel , qemu-stable This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig492033FCE4E6C7A59EABD26A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-09-07 16:41, Peter Maydell wrote: > On 7 September 2012 00:03, Jan Kiszka wrote: >> The old arithmetic assumed 32 physical address bits which is no longer= >> true for ARM since 3cc0cd61f4. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/musicpal.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hw/musicpal.c b/hw/musicpal.c >> index ad725b5..10c2c16 100644 >> --- a/hw/musicpal.c >> +++ b/hw/musicpal.c >> @@ -1583,7 +1583,7 @@ static void musicpal_init(ram_addr_t ram_size, >> * image is smaller than 32 MB. >> */ >> #ifdef TARGET_WORDS_BIGENDIAN >> - pflash_cfi02_register(0-MP_FLASH_SIZE_MAX, NULL, >> + pflash_cfi02_register(0x100000000-MP_FLASH_SIZE_MAX, NULL, >=20 > I don't think this will compile on a 32 bit system, will it? > You probably want an ULL suffix. It does as the result always fits in 32 bits. But I can add that if you prefer. Jan --------------enig492033FCE4E6C7A59EABD26A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBKCmQACgkQitSsb3rl5xT5cgCgh6Z7pzxlSoo/8jWcagzj9fDN 2jEAnRHRaWIH0GACVHDGEjbrZ1octySj =0vb8 -----END PGP SIGNATURE----- --------------enig492033FCE4E6C7A59EABD26A--