From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi Date: Fri, 07 Sep 2012 18:00:50 +0200 Message-ID: <504A1A32.5050705@redhat.com> References: <1347000499-28701-1-git-send-email-nab@linux-iscsi.org> <1347000499-28701-5-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347000499-28701-5-git-send-email-nab@linux-iscsi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Nicholas A. Bellinger" Cc: Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel , Zhi Yong Wu , Anthony Liguori , target-devel , lf-virt , Christoph Hellwig List-Id: virtualization@lists.linuxfoundation.org Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > Cc: Stefan Hajnoczi > Cc: Zhi Yong Wu > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Signed-off-by: Nicholas Bellinger > --- > hw/virtio-pci.c | 2 ++ > hw/virtio-scsi.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > hw/virtio-scsi.h | 1 + > 3 files changed, 52 insertions(+), 0 deletions(-) Please create a completely separate device vhost-scsi-pci instead (or virtio-scsi-tcm-pci, or something like that). It is used completely differently from virtio-scsi-pci, it does not make sense to conflate the two. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA114-0006Wi-ME for qemu-devel@nongnu.org; Fri, 07 Sep 2012 12:02:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TA113-0003qX-Iv for qemu-devel@nongnu.org; Fri, 07 Sep 2012 12:02:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA113-0003qT-Aw for qemu-devel@nongnu.org; Fri, 07 Sep 2012 12:02:45 -0400 Message-ID: <504A1A32.5050705@redhat.com> Date: Fri, 07 Sep 2012 18:00:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1347000499-28701-1-git-send-email-nab@linux-iscsi.org> <1347000499-28701-5-git-send-email-nab@linux-iscsi.org> In-Reply-To: <1347000499-28701-5-git-send-email-nab@linux-iscsi.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Jan Kiszka , Zhi Yong Wu , qemu-devel , Zhi Yong Wu , Anthony Liguori , target-devel , Hannes Reinecke , lf-virt , Christoph Hellwig Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > Cc: Stefan Hajnoczi > Cc: Zhi Yong Wu > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Signed-off-by: Nicholas Bellinger > --- > hw/virtio-pci.c | 2 ++ > hw/virtio-scsi.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > hw/virtio-scsi.h | 1 + > 3 files changed, 52 insertions(+), 0 deletions(-) Please create a completely separate device vhost-scsi-pci instead (or virtio-scsi-tcm-pci, or something like that). It is used completely differently from virtio-scsi-pci, it does not make sense to conflate the two. Paolo