From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-kernel@vger.kernel.org, target-devel@vger.kernel.org,
hch@lst.de, roland@kernel.org
Subject: Re: [PATCH 06/11] target: go through normal processing for zero-length REQUEST_SENSE
Date: Fri, 07 Sep 2012 22:34:25 +0200 [thread overview]
Message-ID: <504A5A51.5060609@redhat.com> (raw)
In-Reply-To: <1347042809.4162.640.camel@haakon2.linux-iscsi.org>
Il 07/09/2012 20:33, Nicholas A. Bellinger ha scritto:
>>> > > if (!cmd->data_length &&
>>> > > + cmd->t_task_cdb[0] != REQUEST_SENSE &&
>>> > > (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
>>> > > cmd->t_task_cdb[0] == REPORT_LUNS) {
>>> > > spin_lock_irq(&cmd->t_state_lock);
> Btw, this section does not compile.
The idea was to add the missing parenthesis to
cmd->t_task_cdb[0] == REPORT_LUNS))
but your fix is also correct after patch 3.
Thanks!
Paolo
next prev parent reply other threads:[~2012-09-07 20:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 15:30 [PATCH 00/11] lots of fixes for zero allocation length Paolo Bonzini
2012-09-07 15:30 ` [PATCH 01/11] target: go through normal processing for zero-length PSCSI commands Paolo Bonzini
2012-09-07 18:06 ` Nicholas A. Bellinger
2012-09-07 15:30 ` [PATCH 02/11] target: report too-small parameter lists everywhere Paolo Bonzini
2012-09-07 18:09 ` Nicholas A. Bellinger
2012-09-07 15:30 ` [PATCH 03/11] target: fail REPORT LUNS with less than 16 bytes of payload Paolo Bonzini
2012-09-07 18:09 ` Nicholas A. Bellinger
2012-09-07 15:30 ` [PATCH 04/11] target: support zero-size allocation lengths in transport_kmap_data_sg Paolo Bonzini
2012-09-07 18:12 ` Nicholas A. Bellinger
2012-09-07 15:30 ` [PATCH 05/11] target: support zero allocation length in REQUEST SENSE Paolo Bonzini
2012-09-07 18:17 ` Nicholas A. Bellinger
2012-09-07 15:30 ` [PATCH 06/11] target: go through normal processing for zero-length REQUEST_SENSE Paolo Bonzini
2012-09-07 18:23 ` Nicholas A. Bellinger
2012-09-07 18:33 ` Nicholas A. Bellinger
2012-09-07 20:34 ` Paolo Bonzini [this message]
2012-09-07 15:30 ` [PATCH 07/11] target: support zero allocation length in INQUIRY Paolo Bonzini
2012-09-07 15:30 ` [PATCH 08/11] target: fix truncation of mode data, support zero allocation length Paolo Bonzini
2012-09-07 15:30 ` [PATCH 09/11] target: support zero allocation length in SBC commands Paolo Bonzini
2012-09-07 15:30 ` [PATCH 10/11] target: do not submit a zero-bio I/O request Paolo Bonzini
2012-09-07 15:30 ` [PATCH 11/11] target: go through normal processing for all zero-length commands Paolo Bonzini
2012-09-07 19:01 ` [PATCH 00/11] lots of fixes for zero allocation length Nicholas A. Bellinger
2012-09-10 7:28 ` Christoph Hellwig
2012-09-10 7:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504A5A51.5060609@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.