All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-next@vger.kernel.org, Daniel Mack <daniel@caiaq.de>
Subject: Re: mmotm 2012-09-06-16-46 uploaded (drivers/misc/lis3lv02d/lis3lv02d_spi.c)
Date: Sat, 08 Sep 2012 12:44:51 +0200	[thread overview]
Message-ID: <504B21A3.3070401@gmail.com> (raw)
In-Reply-To: <504A9644.4070303@xenotime.net>

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

On 08.09.2012 02:50, Randy Dunlap wrote:
> On 09/06/2012 04:47 PM, akpm@linux-foundation.org wrote:
> 
>> The mm-of-the-moment snapshot 2012-09-06-16-46 has been uploaded to
>>
>>    http://www.ozlabs.org/~akpm/mmotm/
>>
> 
> 
> 
> on x86_64:
> 
> CONFIG_OF and CONFIG_DTC are not enabled.
> 
> 
> drivers/misc/lis3lv02d/lis3lv02d_spi.c:137:3: error: implicit declaration of function 'of_match_ptr'
> drivers/misc/lis3lv02d/lis3lv02d_spi.c:137:3: error: initializer element is not constant
> drivers/misc/lis3lv02d/lis3lv02d_spi.c:137:3: error: (near initialization for 'lis302dl_spi_driver.driver.of_match_table')
> 
> 

Thanks - the attached patch fixes it.

Daniel


[-- Attachment #2: 0001-lis3-lis3lv02d_spi.c-include-linux-of.h.patch --]
[-- Type: text/x-patch, Size: 871 bytes --]

>From 3c415511cb825d5b5d015b716e14d720a3d56bf6 Mon Sep 17 00:00:00 2001
From: Daniel Mack <zonque@gmail.com>
Date: Sat, 8 Sep 2012 12:41:33 +0200
Subject: [PATCH] lis3: lis3lv02d_spi.c: include linux/of.h

This include is needed to define of_match:ptr() for !CONFIG_OF &&
1CONFIG_DTC.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/misc/lis3lv02d/lis3lv02d_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/lis3lv02d/lis3lv02d_spi.c b/drivers/misc/lis3lv02d/lis3lv02d_spi.c
index 8616054..23f3986 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d_spi.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d_spi.c
@@ -17,6 +17,7 @@
 #include <linux/workqueue.h>
 #include <linux/spi/spi.h>
 #include <linux/pm.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 
 #include "lis3lv02d.h"
-- 
1.7.11.4


      reply	other threads:[~2012-09-08 10:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 23:47 mmotm 2012-09-06-16-46 uploaded akpm
2012-09-06 23:47 ` akpm
2012-09-07 15:12 ` Michal Hocko
2012-09-07 15:12   ` Michal Hocko
2012-09-07 15:22   ` Fengguang Wu
2012-09-07 15:22     ` Fengguang Wu
2012-09-07 15:23     ` Michal Hocko
2012-09-07 15:23       ` Michal Hocko
2012-09-07 23:45 ` mmotm 2012-09-06-16-46 uploaded (fs/binfmt_aout) Randy Dunlap
2012-09-11 22:17   ` Andrew Morton
2012-09-08  0:39 ` mmotm 2012-09-06-16-46 uploaded (drivers/video/backlight/lm3639_bl) Randy Dunlap
2012-09-10  0:11   ` gshark
2012-09-08  0:50 ` mmotm 2012-09-06-16-46 uploaded (drivers/misc/lis3lv02d/lis3lv02d_spi.c) Randy Dunlap
2012-09-08 10:44   ` Daniel Mack [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504B21A3.3070401@gmail.com \
    --to=zonque@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@caiaq.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.