From: David Ahern <dsahern@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Irina Tirdea <irina.tirdea@gmail.com>,
mingo@redhat.com, acme@ghostprotocols.net,
a.p.zijlstra@chello.nl, rostedt@goodmis.org, paulus@samba.org,
namhyung.kim@lge.com, linux-kernel@vger.kernel.org,
Irina Tirdea <irina.tirdea@intel.com>
Subject: Re: [PATCH v2 05/12] perf tools: include basename for non-glibc systems
Date: Sat, 08 Sep 2012 08:33:50 -0600 [thread overview]
Message-ID: <504B574E.40907@gmail.com> (raw)
In-Reply-To: <CAOJsxLH_8h=GDaC=5MzjiFT1rfN5CHKpPX3PKDDHGubQpV1zuQ@mail.gmail.com>
On 9/8/12 3:09 AM, Pekka Enberg wrote:
> It's safe to include <libgen.h> on glibc Linux systems as well, no? So
> there's no need to check for __BIONIC__.
Theoretically, yes. In reality compile fails in multiple places.
basename can modify the string passed to it and several places in perf
are passing a string marked const. Oops. I'll fix those places and
remove the BIONIC conditional for libgen.h
David
next prev parent reply other threads:[~2012-09-08 14:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 0:43 [PATCH v2 00/12] Porting perf to Android Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 01/12] perf tools: include wrapper for magic.h Irina Tirdea
2012-09-08 9:13 ` Pekka Enberg
2012-09-08 22:39 ` Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 02/12] perf tools: update types definitions for Android Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 03/12] perf tools: include __WORDSIZE definition Irina Tirdea
2012-09-08 9:07 ` Pekka Enberg
2012-09-08 22:19 ` Irina Tirdea
2012-09-10 14:44 ` Peter Zijlstra
2012-09-10 21:42 ` Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 04/12] perf tools: fix ALIGN redefinition in system headers Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 05/12] perf tools: include basename for non-glibc systems Irina Tirdea
2012-09-08 9:09 ` Pekka Enberg
2012-09-08 14:33 ` David Ahern [this message]
2012-09-08 11:43 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 06/12] perf tools: fix missing winsize definition Irina Tirdea
2012-09-08 11:44 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 07/12] perf tools: include missing pthread.h header Irina Tirdea
2012-09-08 11:45 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 08/12] perf tools: fix no return in non-void function Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 09/12] perf tools: replace mkostemp with mkstemp Irina Tirdea
2012-09-08 11:46 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 10/12] tools lib traceevent: replace mempcpy with memcpy Irina Tirdea
2012-09-08 11:47 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 11/12] perf tools: add NO_BACKTRACE for application self-debugging Irina Tirdea
2012-09-08 11:48 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08 0:43 ` [PATCH v2 12/12] perf tools: Use __maybe_used for unused variables Irina Tirdea
2012-09-08 1:14 ` [PATCH v2 00/12] Porting perf to Android Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504B574E.40907@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=irina.tirdea@gmail.com \
--cc=irina.tirdea@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.