From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: Re: [PATCH 5/7] t0000: verify that real_path() works correctly with absolute paths
Date: Sun, 09 Sep 2012 06:31:06 +0200 [thread overview]
Message-ID: <504C1B8A.3000406@alum.mit.edu> (raw)
In-Reply-To: <7v627q21hl.fsf@alter.siamese.dyndns.org>
On 09/07/2012 01:08 AM, Junio C Hamano wrote:
> mhagger@alum.mit.edu writes:
>
>> From: Michael Haggerty <mhagger@alum.mit.edu>
>>
>> There is currently a bug: if passed an absolute top-level path that
>> doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
>> relative path (e.g., returns "$(pwd)/foo"). So mark the test as
>> failing.
>>
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>> ---
>> t/t0000-basic.sh | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
>> index 1a51634..ad002ee 100755
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -458,7 +458,17 @@ test_expect_success 'real path rejects the empty string' '
>> test_must_fail test-path-utils real_path ""
>> '
>>
>> -test_expect_success SYMLINKS 'real path works as expected' '
>> +test_expect_failure 'real path works on absolute paths' '
>> + nopath="hopefully-absent-path" &&
>> + test "/" = "$(test-path-utils real_path "/")" &&
>> + test "/$nopath" = "$(test-path-utils real_path "/$nopath")" &&
>
> You could perhaps do
>
> sfx=0 &&
> while test -e "/$nopath$sfx"
> do
> sfx=$(( $sfx + 1 ))
> done && nopath=$nopath$sfx &&
> test "/$nopath" = "$(test-path-utils real_path "/$nopath")" &&
>
> if you really cared.
The possibility is obvious. Are you advocating it?
I considered that approach, but came to the opinion that it would be
overkill that would only complicate the code for no real advantage,
given that (1) I picked a name that is pretty implausible for an
existing file, (2) the test suite only reads the file, never writes it
(so there is no risk that a copy from a previous run gets left behind),
(3) it's only test suite code, and any failures would have minor
consequences.
Please let me know if you assess the situation differently.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2012-09-09 4:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 8:14 [PATCH 0/7] Fix some bugs in abspath.c mhagger
2012-09-04 8:14 ` [PATCH 1/7] t0000: verify that absolute_path() fails if passed the empty string mhagger
2012-09-04 8:14 ` [PATCH 2/7] absolute_path(): reject " mhagger
2012-09-04 8:14 ` [PATCH 3/7] t0000: verify that real_path() fails if passed " mhagger
2012-09-04 8:14 ` [PATCH 4/7] real_path(): reject " mhagger
2012-09-04 8:14 ` [PATCH 5/7] t0000: verify that real_path() works correctly with absolute paths mhagger
2012-09-05 8:40 ` Johannes Sixt
2012-09-06 21:11 ` Michael Haggerty
2012-09-06 23:08 ` Junio C Hamano
2012-09-09 4:31 ` Michael Haggerty [this message]
2012-09-09 4:50 ` Junio C Hamano
2012-09-09 5:27 ` Junio C Hamano
2012-09-04 8:14 ` [PATCH 6/7] real_path(): properly handle nonexistent top-level paths mhagger
2012-09-04 8:14 ` [PATCH 7/7] t0000: verify that real_path() removes extra slashes mhagger
2012-09-04 18:19 ` Junio C Hamano
2012-09-05 10:52 ` Nguyen Thai Ngoc Duy
[not found] ` <CAGHpTB+LipLt3CgVt5O0s9xj5HHf9Y5z9QWEy+FKYH8s4O7Q2w@mail.gmail.com>
2012-09-05 11:13 ` Nguyen Thai Ngoc Duy
2012-09-06 3:23 ` Junio C Hamano
2012-09-06 5:44 ` Nguyen Thai Ngoc Duy
2012-09-06 17:34 ` Junio C Hamano
2012-09-07 1:18 ` Nguyen Thai Ngoc Duy
2012-09-05 8:40 ` Johannes Sixt
2012-09-06 22:30 ` Michael Haggerty
2012-09-04 18:08 ` [PATCH 0/7] Fix some bugs in abspath.c Junio C Hamano
2012-09-04 19:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504C1B8A.3000406@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.