From: Clemens Ladisch <clemens@ladisch.de>
To: sgiurgiu11@gmail.com
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org
Subject: Re: [PATCH - ALSA: snd-virtuoso 1/1] Xonar DSX support
Date: Sun, 09 Sep 2012 12:03:31 +0200 [thread overview]
Message-ID: <504C6973.6050308@ladisch.de> (raw)
In-Reply-To: <504b9831.aac4320a.1f39.ffff8a9f@mx.google.com>
sgiurgiu11@gmail.com wrote:
> From: Sergiu Giurgiu <sgiurgiu11@gmail.com>
>
> Signed-off-by: Sergiu Giurgiu <sgiurgiu11@gmail.com>
Many thanks for writing this patch!
However, please mention which features work, don't work, or aren't tested.
> +++ b/mirror/sound/pci/oxygen/xonar_wm87x6.c
>
> +static const struct oxygen_model model_xonar_dsx = {
> + .shortname = "Xonar DSX",
> + ...
This structure is almost the same as model_xonar_ds; please merge
them. (See xonar_cs43xx.c for an example.)
Regards,
Clemens
next prev parent reply other threads:[~2012-09-09 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 19:09 [PATCH - ALSA: snd-virtuoso 1/1] Xonar DSX support sgiurgiu11
2012-09-09 10:03 ` Clemens Ladisch [this message]
2012-09-09 8:01 ` Sergiu Giurgiu
2012-09-20 22:55 ` Adriano Angeletti
2012-10-29 3:51 ` jack
-- strict thread matches above, loose matches on Subject: below --
2012-09-09 9:14 sgiurgiu11
2013-09-26 10:07 ` Ian Clarke
2013-09-26 10:17 ` Ian Clarke
2013-09-26 11:05 ` Clemens Ladisch
2015-01-03 6:16 ` Man
2015-01-04 21:56 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504C6973.6050308@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=patch@alsa-project.org \
--cc=sgiurgiu11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.