From: Jens Axboe <axboe@kernel.dk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [block:for-next 7/35] fs/bio.c:363 bio_alloc_bioset() error: we previously assumed 'bs' could be
Date: Sun, 09 Sep 2012 12:22:26 +0000 [thread overview]
Message-ID: <504C8A02.9070409@kernel.dk> (raw)
In-Reply-To: <20120909121511.GA19841@localhost>
On 2012-09-09 14:15, Fengguang Wu wrote:
> Hi Kent,
>
> FYI, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> head: 5611a9dbd54b993fe24f322a0c310a6605824c0f
> commit: 3f86a82aeb03e6100f7ab39f4702e033a5e38166 [7/35] block: Consolidate bio_alloc_bioset(), bio_kmalloc()
The logic in there does look both confusing and broken.
For !bs, we should not enter the bvec_alloc_bs() part. We already have
the vec, plus bvec_alloc_bs() would crap out for !bs. That would exclude
us from hitting err_free as well.
Style issue on nr_iovecs check, too.
--
Jens Axboe
next prev parent reply other threads:[~2012-09-09 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 12:15 [block:for-next 7/35] fs/bio.c:363 bio_alloc_bioset() error: we previously assumed 'bs' could be nul Fengguang Wu
2012-09-09 12:22 ` Jens Axboe [this message]
2012-09-17 22:49 ` [block:for-next 7/35] fs/bio.c:363 bio_alloc_bioset() error: we previously assumed 'bs' could be Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504C8A02.9070409@kernel.dk \
--to=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.