Re: [uml-devel] Emulate I2C subsystem/slaves

[Richard Weinberger <richard@nod.at>]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

Am 09.09.2012 15:11, schrieb Peter Hüwe:
>>>> Maybe some parts of the I2C sub-system can also just depend on
>>>> GENERIC_IO instead of HAS_IOMEM.
>>>> An arch has GENERIC_IO=y if it supports everything defined in
>>>> generic-asm/io.h which is more than enough for most stub drivers.
>>>
>>> The only thing which seems to be missing on UML is the ioremap function
>>> family ;/
>>
>> Why do you need ioremap() in a stub driver?
>> This sounds strange.
> 
> 
> This was a misunderstanding - the main part of the I2C subsystem doesn't 
> depend at all on HAS_IOMEM, only the main part of the i2c/busses section.
> And almost all of those drivers use ioremap.

Sure. They need real hardware. :-)

> For my stub driver I don't need any of that, I'd be fine with the move of 
> HAS_IOMEM as proposed by Jean.

IMHO you should replace the HAS_IOMEM with GENERIC_IO.
Otherwise you may break the build on s390.

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]