From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] support readonly memory feature in qemu Date: Sun, 09 Sep 2012 18:45:55 +0300 Message-ID: <504CB9B3.8010408@redhat.com> References: <1347006389-543-1-git-send-email-liusheng@linux.vnet.ibm.com> <1347006389-543-4-git-send-email-liusheng@linux.vnet.ibm.com> <5049B56B.20707@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, xiaoguangrong@linux.vnet.ibm.com, Liu Sheng To: Jan Kiszka Return-path: In-Reply-To: <5049B56B.20707@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 09/07/2012 11:50 AM, Jan Kiszka wrote: > >> + } else { >> + cpu_physical_memory_rw(run->mmio.phys_addr, >> + run->mmio.data, >> + run->mmio.len, >> + run->mmio.is_write); >> + } >> + >> ret = 0; >> break; >> case KVM_EXIT_IRQ_WINDOW_OPEN: >> > > Great to see this feature for KVM finally! I'm just afraid that this > will finally break good old isapc - due to broken Seabios. KVM used to > "unbreak" it as it didn't respect write protections. ;) Can you describe the breakage? -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAji0-0007Vc-Nu for qemu-devel@nongnu.org; Sun, 09 Sep 2012 11:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAjhz-0002ai-Oc for qemu-devel@nongnu.org; Sun, 09 Sep 2012 11:46:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAjhz-0002ae-GC for qemu-devel@nongnu.org; Sun, 09 Sep 2012 11:46:03 -0400 Message-ID: <504CB9B3.8010408@redhat.com> Date: Sun, 09 Sep 2012 18:45:55 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1347006389-543-1-git-send-email-liusheng@linux.vnet.ibm.com> <1347006389-543-4-git-send-email-liusheng@linux.vnet.ibm.com> <5049B56B.20707@siemens.com> In-Reply-To: <5049B56B.20707@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, xiaoguangrong@linux.vnet.ibm.com, Liu Sheng On 09/07/2012 11:50 AM, Jan Kiszka wrote: > >> + } else { >> + cpu_physical_memory_rw(run->mmio.phys_addr, >> + run->mmio.data, >> + run->mmio.len, >> + run->mmio.is_write); >> + } >> + >> ret = 0; >> break; >> case KVM_EXIT_IRQ_WINDOW_OPEN: >> > > Great to see this feature for KVM finally! I'm just afraid that this > will finally break good old isapc - due to broken Seabios. KVM used to > "unbreak" it as it didn't respect write protections. ;) Can you describe the breakage? -- error compiling committee.c: too many arguments to function