From: Doug Brunner <dbrunner@ebus.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] Queue corruption from XDDP in Xenomai 2.6.1
Date: Sun, 09 Sep 2012 17:19:34 -0700 [thread overview]
Message-ID: <504D3216.7030401@ebus.com> (raw)
In-Reply-To: <504C7797.8040201@xenomai.org>
On 09/09/2012 04:03 AM, Philippe Gerum wrote:
> On 09/06/2012 07:53 AM, Doug Brunner wrote:
>> It looks like the bug I wrote about back in June still exists in Xenomai
>> 2.6.1 (with Linux 3.2.21). I ran the same test case (an RT thread opens
>> an XDDP socket, then a Linux thread opens its end of the pipe, then the
>> RT thread stops, then with the Linux thread still holding its end of the
>> pipe another RT thread tries to open an XDDP socket with the same minor
>> number). With Xenomai queue and I-pipe debugging enabled, I got a report
>> of a corrupted queue. I've attached my config, test case, and serial
>> console log.
>>
>> So far I haven't found anything in the XDDP or underlying xnpipe_* code
>> that would suggest why this is happening. However something is
>> definitely going wrong, since xnpipe_minor_free should not be called
>> until my Linux task closes its end of the pipe, so the call by the
>> second RT thread to open the pipe should fail with -EBUSY. Any thoughts
>> on why this might be happening?
>>
> Yes, please have a look at the commit log there:
> http://git.xenomai.org/?p=xenomai-2.6.git;a=commit;h=283c5f6eae1d1d7c65073e2f30fd40abdcf2c1ca
>
> This patch should fix the issue raised by the test case you sent
> (actually, it does, it was very useful to spot the problem - thanks for
> this).
Thanks Philippe--I will patch this in and try it on my test hardware
tomorrow. (Unfortunately my KVM virtual machine will not boot any 3.2
kernel with I-pipe AFAICT; around the time it remounts the root FS
read-write it begins waiting for something that never happens :( )
--Doug Brunner
next prev parent reply other threads:[~2012-09-10 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 5:53 [Xenomai] Queue corruption from XDDP in Xenomai 2.6.1 Doug Brunner
2012-09-09 11:03 ` Philippe Gerum
2012-09-10 0:19 ` Doug Brunner [this message]
2012-09-11 4:12 ` Doug Brunner
2012-09-11 7:46 ` Gilles Chanteperdrix
2012-09-18 22:30 ` Gilles Chanteperdrix
2012-09-23 14:06 ` Philippe Gerum
2012-09-23 14:07 ` Gilles Chanteperdrix
2012-09-23 14:09 ` Philippe Gerum
2012-09-23 14:11 ` Gilles Chanteperdrix
2012-09-23 14:18 ` Philippe Gerum
2012-09-23 14:21 ` Philippe Gerum
2012-09-23 14:25 ` Philippe Gerum
2012-09-23 14:26 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504D3216.7030401@ebus.com \
--to=dbrunner@ebus.com \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.