From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH uq/master] kvm: Clean up irqfd API Date: Mon, 10 Sep 2012 11:27:16 +0200 Message-ID: <504DB274.5030507@siemens.com> References: <5031FB9C.4050803@siemens.com> <504CA14A.1040107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , qemu-devel , kvm , Alex Williamson , Paolo Bonzini To: Avi Kivity Return-path: Received: from goliath.siemens.de ([192.35.17.28]:19422 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779Ab2IJJ1V (ORCPT ); Mon, 10 Sep 2012 05:27:21 -0400 In-Reply-To: <504CA14A.1040107@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-09-09 16:01, Avi Kivity wrote: > On 08/20/2012 11:55 AM, Jan Kiszka wrote: >> No need to expose the fd-based interface, everyone will already be fine >> with the more handy EventNotifier variant. Rename the latter to clarify >> that we are still talking about irqfds here. > > Thanks, applied. > >> >> -int kvm_irqchip_add_irqfd(KVMState *s, int fd, int virq); >> -int kvm_irqchip_remove_irqfd(KVMState *s, int fd, int virq); >> -int kvm_irqchip_add_irq_notifier(KVMState *s, EventNotifier *n, int virq); >> -int kvm_irqchip_remove_irq_notifier(KVMState *s, EventNotifier *n, int virq); >> +int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); >> +int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); >> #endif > > Those names aren't particularly satisfying. add_irqfd_notifier implies > you want to be notified about irqfd events, but that's not what the > function does. Not sure what a good name would be. Now that there are no more variants, we could also drop the "notifier" from the name again. Better? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB0HC-0006gc-B0 for qemu-devel@nongnu.org; Mon, 10 Sep 2012 05:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB0H0-0001N6-Ql for qemu-devel@nongnu.org; Mon, 10 Sep 2012 05:27:30 -0400 Received: from goliath.siemens.de ([192.35.17.28]:33342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB0H0-0001Mz-Fd for qemu-devel@nongnu.org; Mon, 10 Sep 2012 05:27:18 -0400 Message-ID: <504DB274.5030507@siemens.com> Date: Mon, 10 Sep 2012 11:27:16 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <5031FB9C.4050803@siemens.com> <504CA14A.1040107@redhat.com> In-Reply-To: <504CA14A.1040107@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH uq/master] kvm: Clean up irqfd API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Paolo Bonzini , Alex Williamson , Marcelo Tosatti , qemu-devel , kvm On 2012-09-09 16:01, Avi Kivity wrote: > On 08/20/2012 11:55 AM, Jan Kiszka wrote: >> No need to expose the fd-based interface, everyone will already be fine >> with the more handy EventNotifier variant. Rename the latter to clarify >> that we are still talking about irqfds here. > > Thanks, applied. > >> >> -int kvm_irqchip_add_irqfd(KVMState *s, int fd, int virq); >> -int kvm_irqchip_remove_irqfd(KVMState *s, int fd, int virq); >> -int kvm_irqchip_add_irq_notifier(KVMState *s, EventNotifier *n, int virq); >> -int kvm_irqchip_remove_irq_notifier(KVMState *s, EventNotifier *n, int virq); >> +int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); >> +int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); >> #endif > > Those names aren't particularly satisfying. add_irqfd_notifier implies > you want to be notified about irqfd events, but that's not what the > function does. Not sure what a good name would be. Now that there are no more variants, we could also drop the "notifier" from the name again. Better? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux