From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 10 Sep 2012 14:57:41 +0530 Subject: [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work In-Reply-To: References: <1345471731-31678-1-git-send-email-prabhakar.lad@ti.com> <1345471731-31678-3-git-send-email-prabhakar.lad@ti.com> <504A2C7D.1090702@ti.com> Message-ID: <504DB28D.3070005@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Prabhakar, On 9/7/2012 11:04 PM, Prabhakar Lad wrote: > On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori wrote: >>> +static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = { >>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT) >> >> You agreed to get rid of these multiple ifdefs but you have not fixed that. >> > I have merged the top one, at later stage when we go ahead and add sensor > support then we would have require to have define two > da850_vpif_capture_sdev_info > so to avoid it I have kept this one. Lets get to that when we actually add sensor support. It might make sense then. Right now, there is no reason to have them. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756460Ab2IJJ1y (ORCPT ); Mon, 10 Sep 2012 05:27:54 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56342 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754623Ab2IJJ1x (ORCPT ); Mon, 10 Sep 2012 05:27:53 -0400 Message-ID: <504DB28D.3070005@ti.com> Date: Mon, 10 Sep 2012 14:57:41 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Prabhakar Lad CC: Prabhakar Lad , dlos , , Subject: Re: [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work References: <1345471731-31678-1-git-send-email-prabhakar.lad@ti.com> <1345471731-31678-3-git-send-email-prabhakar.lad@ti.com> <504A2C7D.1090702@ti.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On 9/7/2012 11:04 PM, Prabhakar Lad wrote: > On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori wrote: >>> +static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = { >>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT) >> >> You agreed to get rid of these multiple ifdefs but you have not fixed that. >> > I have merged the top one, at later stage when we go ahead and add sensor > support then we would have require to have define two > da850_vpif_capture_sdev_info > so to avoid it I have kept this one. Lets get to that when we actually add sensor support. It might make sense then. Right now, there is no reason to have them. Thanks, Sekhar