Re: [PATCH 4/5] DocBook: update ioctl error codes

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 15-08-2012 21:28, Antti Palosaari escreveu:
> ENOTTY is now returned for unimplemented ioctl by dvb-frontend.
> Old EOPNOTSUPP & ENOSYS could be still returned by some drivers
> as well as other "non standard" error codes.
> 
> EAGAIN is returned in case of device is in state where it cannot
> perform requested operation. This is for example sleep and statistics
> are queried. Quick check for few demodulator drivers reveals there is
> a lot of different error codes used in such case currently, few to
> mention still: EOPNOTSUPP, ENOSYS, EAGAIN ... Lets try harmonize.
> 
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
>  Documentation/DocBook/media/v4l/gen-errors.xml | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/gen-errors.xml b/Documentation/DocBook/media/v4l/gen-errors.xml
> index 5bbf3ce..737ecaa 100644
> --- a/Documentation/DocBook/media/v4l/gen-errors.xml
> +++ b/Documentation/DocBook/media/v4l/gen-errors.xml
> @@ -7,6 +7,13 @@
>      <tbody valign="top">
>  	<!-- Keep it ordered alphabetically -->
>        <row>
> +	<entry>EAGAIN</entry>
> +	<entry>The ioctl can't be handled because the device is in state where
> +	       it can't perform it. This could happen for example in case where
> +	       device is sleeping and ioctl is performed to query statistics.

While the comments here actually depend on your new version of patch 3/5, 
returning -EAGAIN is a valid return code, already used (there are 155 
occurrences of it right now).

So, I'll apply it.


> +	</entry>
> +      </row>
> +      <row>
>  	<entry>EBADF</entry>
>  	<entry>The file descriptor is not a valid.</entry>
>        </row>
> @@ -51,11 +58,6 @@
>  	       for periodic transfers (up to 80% of the USB bandwidth).</entry>
>        </row>
>        <row>
> -	<entry>ENOSYS or EOPNOTSUPP</entry>
> -	<entry>Function not available for this device (dvb API only. Will likely
> -	       be replaced anytime soon by ENOTTY).</entry>
> -      </row>
> -      <row>
>  	<entry>EPERM</entry>
>  	<entry>Permission denied. Can be returned if the device needs write
>  		permission, or some special capabilities is needed
> 

Regards,
Mauro