From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH] drm/i915: rip out edp special case from dp_link_down Date: Mon, 10 Sep 2012 12:15:40 -0400 Message-ID: <504E122C.6070707@redhat.com> References: <1347213536-20340-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 73ACF9E844 for ; Mon, 10 Sep 2012 09:15:43 -0700 (PDT) In-Reply-To: <1347213536-20340-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 9/9/12 1:58 PM, Daniel Vetter wrote: > The really interesting question is how this special cases survived > this long in the code. The first step is declaring the pch port D as > eDP if it's used for an internal panel: > > commit b329530ca7cdf6bf014f2124efd983e01265d623 > Author: Adam Jackson > Date: Fri Jul 16 14:46:28 2010 -0400 > > drm/i915/dp: Correctly report eDP in the core connector type > > This commit unfortunately failed to notice that not all edp ports are > created equal. Then follow a flurry of refactorings, culminating in a > patch from Keith Packard which resulted in the current logic (by > making it "correct" for all platforms that have edp): The motivation for this patch was simply making eDP connectors be reported as eDP, since that has the same "probably special" properties as LVDS (correlation with lid state, probably the primary if no better guidance given, etc). - ajax