From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data Date: Mon, 10 Sep 2012 12:21:09 -0600 Message-ID: <504E2F95.6040808@wwwdotorg.org> References: <20120829084911.GE28643@pengutronix.de> <1346230295-15898-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1346230295-15898-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= Cc: Laxman Dewangan , Arnd Bergmann , Olof Johansson , Vinod Koul , djbw-b10kYP2dOMg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/29/2012 02:51 AM, Uwe Kleine-K=C3=B6nig wrote: > From: Laxman Dewangan >=20 > This prepares *of_device_id.data becoming const. Without this change > the following warning would occur: >=20 > drivers/dma/tegra20-apb-dma.c: In function 'tegra_dma_probe': > drivers/dma/tegra20-apb-dma.c:1210:9: warning: assignment discards '= const' qualifier from pointer target type [enabled by default] >=20 > [ukl: split Laxman's patch to prevent warnings in the middle of the > series. Original patch was sent with msgid > 1346217447-19730-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org] >=20 > Signed-off-by: Laxman Dewangan > Acked-by: Stephen Warren > Acked-by: Vinod Koul > Signed-off-by: Uwe Kleine-K=C3=B6nig Uwe, I don't see these patches in linux-next, so compilation is still broken= =2E Can you please apply them? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932081Ab2IJSVP (ORCPT ); Mon, 10 Sep 2012 14:21:15 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:49673 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495Ab2IJSVN (ORCPT ); Mon, 10 Sep 2012 14:21:13 -0400 Message-ID: <504E2F95.6040808@wwwdotorg.org> Date: Mon, 10 Sep 2012 12:21:09 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= CC: Laxman Dewangan , Arnd Bergmann , Olof Johansson , Vinod Koul , djbw@fb.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data References: <20120829084911.GE28643@pengutronix.de> <1346230295-15898-1-git-send-email-u.kleine-koenig@pengutronix.de> In-Reply-To: <1346230295-15898-1-git-send-email-u.kleine-koenig@pengutronix.de> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2012 02:51 AM, Uwe Kleine-König wrote: > From: Laxman Dewangan > > This prepares *of_device_id.data becoming const. Without this change > the following warning would occur: > > drivers/dma/tegra20-apb-dma.c: In function 'tegra_dma_probe': > drivers/dma/tegra20-apb-dma.c:1210:9: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] > > [ukl: split Laxman's patch to prevent warnings in the middle of the > series. Original patch was sent with msgid > 1346217447-19730-1-git-send-email-ldewangan@nvidia.com] > > Signed-off-by: Laxman Dewangan > Acked-by: Stephen Warren > Acked-by: Vinod Koul > Signed-off-by: Uwe Kleine-König Uwe, I don't see these patches in linux-next, so compilation is still broken. Can you please apply them? Thanks.