From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Ott Subject: Re: RFC: mac802154 Packet Queueing and Slave Devices Date: Mon, 10 Sep 2012 23:00:44 -0400 Message-ID: <504EA95C.9010003@signal11.us> References: <504D37A7.60109@signal11.us> <1347257547.1234.1110.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Eric Dumazet Return-path: In-Reply-To: <1347257547.1234.1110.camel@edumazet-glaptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org On 09/10/2012 02:12 AM, Eric Dumazet wrote: > On Sun, 2012-09-09 at 20:43 -0400, Alan Ott wrote: >> Tony and I were recently talking about packet queueing on 802.15.4. >> >> The problem with this is that it defeats the netif flow control. > And qdisc ability to better control bufferbloat... > > By the way, mac802154_tx() looks buggy : > > Also mac802154_wpan_xmit() returns NETDEV_TX_OK without kfree_skb(skb) > Hi Eric, Thanks for the review. I'll get this patched up. Alan. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/