From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] watchdog: Convert twl4030_wdt to watchdog core Date: Tue, 11 Sep 2012 08:50:07 +0300 Message-ID: <504ED10F.7090008@jollamobile.com> References: <1347291886-15218-1-git-send-email-jarkko.nikula@jollamobile.com> <20120910215946.GB26184@blackmetal.musicnaut.iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp170.iad.emailsrvr.com ([207.97.245.170]:50891 "EHLO smtp170.iad.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251Ab2IKFuW (ORCPT ); Tue, 11 Sep 2012 01:50:22 -0400 In-Reply-To: <20120910215946.GB26184@blackmetal.musicnaut.iki.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Aaro Koskinen Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-omap@vger.kernel.org Thanks Aaro! On 09/11/2012 12:59 AM, Aaro Koskinen wrote: > On Mon, Sep 10, 2012 at 06:44:46PM +0300, Jarkko Nikula wrote: >> Convert the twl4030_wdt watchdog driver to watchdog core. >> >> While at there use devm_kzalloc and set the default timeout in order to be >> able test this driver with a simple shell script. >> >> Signed-off-by: Jarkko Nikula >> --- >> drivers/watchdog/Kconfig | 1 + >> drivers/watchdog/twl4030_wdt.c | 183 ++++++++-------------------------------- >> 2 files changed, 35 insertions(+), 149 deletions(-) >> >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index 53d7571..21f6205 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -232,6 +232,7 @@ config EP93XX_WATCHDOG >> config OMAP_WATCHDOG >> tristate "OMAP Watchdog" >> depends on ARCH_OMAP16XX || ARCH_OMAP2PLUS >> + select WATCHDOG_CORE > This should be under TWL4030_WATCHDOG. Grr.. leftover from testing your patch and accidentally dropping my change :-) I'll fix this, add your Tested-by and repost. -- Jarkko