Re: [PATCH] allow gpiolib to be a module

[Ryan Mallon <rmallon@gmail.com>]

On 10/09/12 22:16, Jan Beulich wrote:
> Without ARCH_REQUIRE_GPIOLIB there's no reason to force this code, when
> enabled, to always be built into the kernel, which requires only minor
> Makefile and source code adjustments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> ---

<snip>

> +#ifdef MODULE
> +int __init gpiolib_init(void)

Should be static.

> +{
> +	return gpiolib_sysfs_init() ?: gpiolib_debugfs_init();

I thought this was going to call gpiolib_sysfs_init() twice until I
looked at gcc's documentation. Maybe the less obtuse, and far more common:

  int err;

  err = gpiolib_sysfs_init();
  if (err)
          return err;

  return gpiolib_debugfs_init();

?

> +}
> +module_init(gpiolib_init);

~Ryan