Re: Cannot create subvolume with quota enabled

[Arne Jansen <sensille@gmx.net>]

On 11.09.2012 07:24, Marios Titas wrote:
> On Fri, Sep 7, 2012 at 6:04 PM, Arne Jansen <sensille@gmx.net> wrote:
>> Hi Andreas,
>>
>>
>> Thanks for giving quota a try. I sent a fix separately with
>> the subject
>>
>> [PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error
>>
>> Could you please see if it fixes the problem?
> 
> Even with this patch I still have a similar problem: When I try to
> create a snapshot of an old subvolume that was created before I
> enabled quotas, it fails. For new subvolumes it works just fine.
> Here's an example ouput:
> 
> virtual ~ # btrfs sub snap /mnt/butter/old /mnt/butter/old-snap
> Create a snapshot of '/mnt/butter/old' in '/mnt/butter/old-snap'
> ERROR: cannot snapshot '/mnt/butter/old' - Invalid argument

instead of applying my patch, could you please just revert

commit 5986802c2fcc754040bb7ed95f30bb16c4a843b7
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Mon Jul 30 02:16:10 2012 -0600

    Btrfs: fix some error codes in btrfs_qgroup_inherit()

It introduces both faulty return codes.

Thanks,
Arne