From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net-next.git 5/8] stmmac: get/set coalesce parameters via ethtool
Date: Tue, 11 Sep 2012 08:58:02 +0200 [thread overview]
Message-ID: <504EE0FA.8050907@st.com> (raw)
In-Reply-To: <1347295510.2823.4.camel@bwh-desktop.uk.solarflarecom.com>
Hello Ben
On 9/10/2012 6:45 PM, Ben Hutchings wrote:
> You should also check that the settings you don't support
> (rx_max_coalesced_frames, use_adaptive_rx_coalesce,
> use_adaptive_tx_coalesce, *_irq) are equal to 0. (This isn't done
> consistently in all drivers - but I believe best practice is to reject
> rather than quietly ignoring settings you don't support.)
Agreed. I've added this check in ethtool and now, for example, I get the
following on un-supported setting
$ ethtool -C eth0 tx-usecs-irq 50
Cannot set device ring parameters: Operation not supported
$ ethtool -C eth0 tx-usecs-irq 0
tx-usecs-irq unmodified, ignoring
no ring parameters changed, aborting
>
> I don't have time to review the other changes properly, but at a quick
> look they seem to be OK.
Thanks a lot
peppe
>
> Ben.
>
next prev parent reply other threads:[~2012-09-11 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 7:38 [net-next.git 0/8 (V3)] stmmac: remove dead code for STMMAC_TIMER and add new mitigation schema Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 1/8] stmmac: remove dead code for TIMER Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 2/8 (V2)] stmmac: manage tx clean out of rx_poll Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 3/8 (V2)] stmmac: add the initial tx coalesce schema Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 4/8 (V3)] stmmac: add Rx watchdog support to mitigate the DMA irqs Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 5/8] stmmac: get/set coalesce parameters via ethtool Giuseppe CAVALLARO
2012-09-10 16:45 ` Ben Hutchings
2012-09-11 6:58 ` Giuseppe CAVALLARO [this message]
2012-09-10 7:38 ` [net-next.git 6/8] stmmac: fix and review the rx irq path after adding new mitigation Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 7/8] stmmac: update the doc with new IRQ mitigation Giuseppe CAVALLARO
2012-09-10 7:38 ` [net-next.git 8/8] stmmac: update the driver version to Sept_2012 Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EE0FA.8050907@st.com \
--to=peppe.cavallaro@st.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.