Re: [PATCHv5][meta-oe 1/2] liblockdev: new recipe, new version of libcec requires it

[Jack Mitchell <ml@communistcode.co.uk>]

On 10/09/12 21:13, Andrei Gherzan wrote:
> On Thu, Sep 6, 2012 at 2:35 PM, <ml@communistcode.co.uk> wrote:
>
>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>
>> V5
>>
>> - FILES_{PN} no loger required now libdir and includedir are passed to
>> oe_runmake
>>
>> V4
>>
>> - Remove debian packaging patch, it is not needed
>>
>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>> ---
>>   .../recipes-extended/liblockdev/liblockdev_1.0.3.bb  | 20
>> ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>   create mode 100644 meta-oe/recipes-extended/liblockdev/
>> liblockdev_1.0.3.bb
>>
>> diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bbb/meta-oe/recipes-extended/liblockdev/
>> liblockdev_1.0.3.bb
>> new file mode 100644
>> index 0000000..210a47b
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
>> @@ -0,0 +1,20 @@
>> +DESCRIPTION = "Manage character and block device lockfiles."
>> +HOMEPAGE = "
>> http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary"
>> +
>> +LICENSE = "LGPLv2.1"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499"
>> +
>> +SRC_URI = "
>> http://ftp.de.debian.org/debian/pool/main/l/lockdev/lockdev_${PV}.orig.tar.gz
>> "
>> +
>> +SRC_URI[md5sum] = "64b9c1b87b125fc348e892e24625524a"
>> +SRC_URI[sha256sum] =
>> "ccae635d7ac3fdd50897eceb250872b3d9a191d298f213e7f0c836910d869f82"
>> +
>> +S = "${WORKDIR}/lockdev-${PV}"
>> +
>> +do_compile() {
>> +  oe_runmake CC="${CC}" LD="${LD}" shared
>> +}
>> +
>> +do_install() {
>> +  oe_runmake basedir="${D}" incdir="${D}${includedir}"
>> libdir="${D}${libdir}" install_dev
>> +}
>>
> Why install only _dev? Why don't you use make install? It makes no sense to
> compile shared and not install it... I just tested your recipe.
>
> ag
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Ah, well spotted I had -dev as that was what I needed to get libcec to 
link - did you have to change anything other than install_dev to install?

Cheers,


-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--