From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-watchdog@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, jarkko.nikula@bitmer.com
Subject: Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core
Date: Tue, 11 Sep 2012 15:29:53 +0530 [thread overview]
Message-ID: <504F0B99.5090500@ti.com> (raw)
In-Reply-To: <1347127441-23125-1-git-send-email-aaro.koskinen@iki.fi>
On Saturday 08 September 2012 11:34 PM, Aaro Koskinen wrote:
> -static struct platform_device *omap_wdt_dev;
> -
> static unsigned timer_margin;
> module_param(timer_margin, uint, 0);
> MODULE_PARM_DESC(timer_margin, "initial watchdog timeout (in seconds)");
>
> -static unsigned int wdt_trgr_pattern = 0x1234;
> -static DEFINE_SPINLOCK(wdt_lock);
> -
you may want to describe this more.
> struct omap_wdt_dev {
> void __iomem *base; /* physical */
> struct device *dev;
> - int omap_wdt_users;
> + bool omap_wdt_users;
> struct resource *mem;
> - struct miscdevice omap_wdt_miscdev;
> + int wdt_trgr_pattern;
> + struct mutex lock; /* to avoid races with PM */
> };
>
prev parent reply other threads:[~2012-09-11 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 18:04 [PATCH v2] watchdog: omap_wdt: convert to new watchdog core Aaro Koskinen
2012-09-10 6:45 ` Jarkko Nikula
2012-09-10 9:32 ` Vutla, Lokesh
2012-09-11 9:59 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F0B99.5090500@ti.com \
--to=shubhrajyoti@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.