All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"afaerber@suse.de" <afaerber@suse.de>,
	"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration
Date: Tue, 11 Sep 2012 12:27:05 +0100	[thread overview]
Message-ID: <504F2009.9040900@citrix.com> (raw)
In-Reply-To: <504F037D.7020207@redhat.com>

On 09/11/2012 10:25 AM, Avi Kivity wrote:
> On 09/11/2012 12:15 PM, Avi Kivity wrote:
>    
>> On 09/04/2012 06:13 PM, Julien Grall wrote:
>>      
>>> This is the nineth version of patch series about ioport registration.
>>>
>>> Some part of QEMU still use register_ioport* functions to register ioport.
>>> These functions doesn't allow to use Memory Listener on it.
>>>        
>> Thanks, applied all (w/ updated patch 4), will push shortly.
>>
>>
>>      
> Aborts with the command line
>
>    qemu-system-x86_64 -device isa-debugcon,iobase=0x402,chardev=stdio -chardev stdio,id=stdio
>
>
>    

I have bisected and found the problem with bochs_bios_init in hw/pc.c.
Bosch already register the iport 0x402. I'm not sure that it's a bug.
In fact register_ioport_read/write check if the current ioport is used
with the opaque variable.
Before my patch, bochs_bios_init registered it's ioport with opaque
NULL, so if someone (like debugcon) wants to use the ioport there is
no problem. But now, I used portio_list_init to register bochs ioport,
so the opaque is not NULL.
I don't really know how to resolve this problem. Perhaps we could
just improve the debug message.

-- 
Julien Grall

  reply	other threads:[~2012-09-11 11:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 15:13 [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 1/8] isa: add isa_address_space_io Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 2/8] hw/apm.c: replace register_ioport* Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 3/8] smb: replace_register_ioport* Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace register_ioport* Julien Grall
2012-09-09 14:22   ` Avi Kivity
2012-09-10 10:37     ` Julien Grall
2012-09-10 10:44       ` Avi Kivity
2012-09-10 17:27         ` Julien Grall
2012-09-10 17:29           ` Jan Kiszka
2012-09-10 17:41             ` Stefano Stabellini
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 5/8] hw/cirrus_vga.c: " Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 6/8] hw/serial.c: " Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 7/8] hw/pc.c: " Julien Grall
2012-09-04 15:13 ` [Qemu-devel] [PATCH V9 8/8] hw/dma.c: " Julien Grall
2012-09-04 22:04 ` [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration Julien Grall
2012-09-10 17:53 ` [Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace register_ioport* Julien Grall
2012-09-11  9:15 ` [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration Avi Kivity
2012-09-11  9:25   ` Avi Kivity
2012-09-11 11:27     ` Julien Grall [this message]
2012-09-11 11:48       ` Jan Kiszka
2012-09-11 11:57         ` [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default Jan Kiszka
2012-09-11 12:14           ` Julien Grall
2012-09-11 12:19             ` Jan Kiszka
2012-09-11 12:53           ` Avi Kivity
2012-09-11 14:11             ` Jan Kiszka
2012-09-11 14:19               ` Avi Kivity
2012-09-11 14:26                 ` Jan Kiszka
2012-09-11 14:34                   ` Andreas Färber
2012-09-19 10:08 ` [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504F2009.9040900@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=afaerber@suse.de \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.