All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Ganir <chen.ganir@ti.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2] gatt: Delay D-Bus reply on char discovery
Date: Tue, 11 Sep 2012 15:36:46 +0300	[thread overview]
Message-ID: <504F305E.1080404@ti.com> (raw)
In-Reply-To: <CAJdJm_OMtRy08-55cxrWH-0WM06r0M8JAH8wHw0a8S11k2hO+Q@mail.gmail.com>

Anderson,
On 09/11/2012 03:27 PM, Anderson Lizardo wrote:
> Hi Chen,
>
> On Tue, Sep 11, 2012 at 8:22 AM, Chen Ganir <chen.ganir@ti.com> wrote:
>> The plan is to replace characteristic::format, and add CCC, SCC and any
>> other descriptor we find in the future to this list. This way we have a
>> unified list of descriptors and the data contained in them. This is already
>> done in some patches i already have, which rely on this patch. Next patch
>> set includes notification/indication implementation to the D-Bus API (Auto
>> registration to notification/indication if CCC is found).
>
> Do you have patches ready for adding CCC support on GATT D-Bus API ?
> Are you planning to send soon to the list, or could send it as RFC?
>
> Best Regards,
>
I already have those patches running. Some cleanup is still needed, and 
this patch also needs to be upstreamed.

Basically what i did was discover the CCC, SCC and extended properties. 
I save them (current value and handle) in the descriptor list. Once the 
entire characteristic range is discovered, and a watcher is registered, 
i check the characteristic properties and cross it with the availability 
of the CCC. Then, i try to automatically enable indication or 
notification according to the characteristic properties.

when the watcher is abandoned or unregistered, i unset the 
notification/indication for all the characters of that service.

In addition, i plan to add a property called "Broadcast" which will be 
read/write, and it will set/get the SCC descriptor of the char.



-- 
BR,
Chen Ganir


  reply	other threads:[~2012-09-11 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11  8:47 [PATCH v2] gatt: Delay D-Bus reply on char discovery chen.ganir
2012-09-11 11:44 ` Anderson Lizardo
2012-09-11 12:22   ` Chen Ganir
2012-09-11 12:27     ` Anderson Lizardo
2012-09-11 12:36       ` Chen Ganir [this message]
2012-09-21 13:19 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504F305E.1080404@ti.com \
    --to=chen.ganir@ti.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.