From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRBq-00007o-5i for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:11:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBRBa-0006eq-Vb for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:11:46 -0400 Received: from goliath.siemens.de ([192.35.17.28]:23458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRBa-0006dv-L3 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:11:30 -0400 Message-ID: <504F4688.2090201@siemens.com> Date: Tue, 11 Sep 2012 16:11:20 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <504F0131.6090501@redhat.com> <504F037D.7020207@redhat.com> <504F2009.9040900@citrix.com> <504F24F8.5080600@siemens.com> <504F273B.4050602@siemens.com> <504F345D.1020807@redhat.com> In-Reply-To: <504F345D.1020807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Julien Grall , Stefano Stabellini , "qemu-devel@nongnu.org" , "afaerber@suse.de" , "kraxel@redhat.com" On 2012-09-11 14:53, Avi Kivity wrote: > On 09/11/2012 02:57 PM, Jan Kiszka wrote: > >> Only listen on debug ports when we also handle them. They are better >> handled by debugcon these days which is runtime configurable. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/pc.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/hw/pc.c b/hw/pc.c >> index 112739a..134d5f7 100644 >> --- a/hw/pc.c >> +++ b/hw/pc.c >> @@ -539,12 +539,12 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) >> case 0x401: >> /* used to be panic, now unused */ >> break; >> +#ifdef DEBUG_BIOS >> case 0x402: >> case 0x403: >> -#ifdef DEBUG_BIOS >> fprintf(stderr, "%c", val); >> -#endif >> break; >> +#endif >> case 0x8900: >> /* same as Bochs power off */ >> if (val == shutdown_str[shutdown_index]) { >> @@ -598,8 +598,10 @@ static void *bochs_bios_init(void) >> >> register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); >> register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); >> +#ifdef DEBUG_BIOS >> register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); >> register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); >> +#endif >> register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); >> >> register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); >> > > > Why not drop DEBUG_BIOS completely? If you want to debug the bios, use > debugcon. Probably true. There is more practically dead stuff below this that just prints if DEBUG_BIOS is enabled. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux