From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRlW-0003IO-IE for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBRlM-000254-Qk for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:48:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57388 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRlM-00024y-HJ for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:48:28 -0400 Message-ID: <504F4F38.3040401@suse.de> Date: Tue, 11 Sep 2012 16:48:24 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <504F4CE1.7020405@siemens.com> In-Reply-To: <504F4CE1.7020405@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Stefano Stabellini , qemu-devel , Julien Grall , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Avi Kivity , Gerd Hoffmann Am 11.09.2012 16:38, schrieb Jan Kiszka: > We have debugcon these days to listen on those ports that receive debug > messages. Also drop the others that have no effect anymore. >=20 > Signed-off-by: Jan Kiszka This looks pretty identical to Herv=E9's "pc: remove DEBUG_BIOS define an= d QEMU exit I/O ports", doesn't it? The discussion there concluded that compatibility needs to be provided for older machines. http://patchwork.ozlabs.org/patch/169542/ http://patchwork.ozlabs.org/patch/169543/ Andreas > --- > hw/pc.c | 27 --------------------------- > 1 files changed, 0 insertions(+), 27 deletions(-) >=20 > diff --git a/hw/pc.c b/hw/pc.c > index 112739a..7e7e0e2 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -53,9 +53,6 @@ > #include "bitmap.h" > #include "vga-pci.h" > =20 > -/* output Bochs bios info messages */ > -//#define DEBUG_BIOS > - > /* debug PC/ISA interrupts */ > //#define DEBUG_IRQ > =20 > @@ -534,17 +531,6 @@ static void bochs_bios_write(void *opaque, uint32_= t addr, uint32_t val) > static int shutdown_index =3D 0; > =20 > switch(addr) { > - /* Bochs BIOS messages */ > - case 0x400: > - case 0x401: > - /* used to be panic, now unused */ > - break; > - case 0x402: > - case 0x403: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > case 0x8900: > /* same as Bochs power off */ > if (val =3D=3D shutdown_str[shutdown_index]) { > @@ -558,16 +544,9 @@ static void bochs_bios_write(void *opaque, uint32_= t addr, uint32_t val) > } > break; > =20 > - /* LGPL'ed VGA BIOS messages */ > case 0x501: > case 0x502: > exit((val << 1) | 1); > - case 0x500: > - case 0x503: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > } > } > =20 > @@ -596,17 +575,11 @@ static void *bochs_bios_init(void) > uint64_t *numa_fw_cfg; > int i, j; > =20 > - register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); > register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); > =20 > register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); > register_ioport_write(0x501, 1, 2, bochs_bios_write, NULL); > register_ioport_write(0x502, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x500, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x503, 1, 1, bochs_bios_write, NULL); > =20 > fw_cfg =3D fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 1, 0, 0)= ; > =20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg