From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBS1J-0000yf-NW for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:05:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBS1D-00088q-Ef for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:04:57 -0400 Received: from david.siemens.de ([192.35.17.14]:25688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBS1D-000887-4X for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:04:51 -0400 Message-ID: <504F530B.3030106@siemens.com> Date: Tue, 11 Sep 2012 17:04:43 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <504F4CE1.7020405@siemens.com> <504F4F38.3040401@suse.de> In-Reply-To: <504F4F38.3040401@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , Stefano Stabellini , qemu-devel , Julien Grall , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Avi Kivity , Gerd Hoffmann On 2012-09-11 16:48, Andreas F=E4rber wrote: > Am 11.09.2012 16:38, schrieb Jan Kiszka: >> We have debugcon these days to listen on those ports that receive debu= g >> messages. Also drop the others that have no effect anymore. >> >> Signed-off-by: Jan Kiszka >=20 > This looks pretty identical to Herv=E9's "pc: remove DEBUG_BIOS define = and > QEMU exit I/O ports", doesn't it? The discussion there concluded that > compatibility needs to be provided for older machines. I'm not removing any behaviour that can be achieved _without_ additionally patching QEMU. I'm just removing practically dead debug code, leaving in the bits that do have effects. Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux