From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TBSNA-000099-Pp
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:27:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TBSN4-0007cT-EX
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:27:32 -0400
Received: from goliath.siemens.de ([192.35.17.28]:34419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TBSN4-0007bs-50
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:27:26 -0400
Message-ID: <504F5855.9030807@siemens.com>
Date: Tue, 11 Sep 2012 17:27:17 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <504F4CE1.7020405@siemens.com> <504F4F38.3040401@suse.de>
	<504F530B.3030106@siemens.com> <504F54AB.6000406@suse.de>
In-Reply-To: <504F54AB.6000406@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS
 debug ports
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel <qemu-devel@nongnu.org>, Julien Grall <julien.grall@citrix.com>, =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, Avi Kivity <avi@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On 2012-09-11 17:11, Andreas F=E4rber wrote:
> Am 11.09.2012 17:04, schrieb Jan Kiszka:
>> On 2012-09-11 16:48, Andreas F=E4rber wrote:
>>> Am 11.09.2012 16:38, schrieb Jan Kiszka:
>>>> We have debugcon these days to listen on those ports that receive de=
bug
>>>> messages. Also drop the others that have no effect anymore.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This looks pretty identical to Herv=E9's "pc: remove DEBUG_BIOS defin=
e and
>>> QEMU exit I/O ports", doesn't it? The discussion there concluded that
>>> compatibility needs to be provided for older machines.
>>
>> I'm not removing any behaviour that can be achieved _without_
>> additionally patching QEMU. I'm just removing practically dead debug
>> code, leaving in the bits that do have effects.
>=20
> Didn't want to argue about that, just pointing you to the discussion
> thread that you have snipped above. It was Anthony's request. ;)

The 2nd patch cited did more than what my patch does by making those
ports optional (and apparently default off) that do have effect.

Jan

--=20
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux