On 08/23/2012 01:53 PM, Sergey Senozhatsky wrote: > On (08/23/12 09:57), Chris Ferron wrote: >> So this may be nice for the tuning tab, but we have an overall issue >> with other tabs as well. >> Maybe we should change the controls around, and just move the pad. >> That way we could scroll all tabs and not have to truncate strings. >> ? >> -Chris >> > That was the first one in a upcoming series of patches. > Because we have separate display logic on every tab, I was moving in a > direction of teaching each tabs honour resize. > > >> Maybe we should change the controls around, and just move the pad. >> That way we could scroll all tabs and not have to truncate strings. > Sorry, I'm not sure I got this one, could you please elaborate? > > We can't avaoid string truncation (unless we introduce support for horizontal > scrolling as well) when X becomes smaller than the longest string in tab > (we actually can just ignore it and print beyond the sceen, but I think the > common behaviour in that case is to let user notice that text has been truncated > via ~ for example). I don't know what to do with C, P states tab when we only > have space for "Package" and "Core", or when half of currently required X space for > "Frequency stats" tab is available -- dynamic re-arrange looks a bit complex at > the moment. > > As of Y scroll, well, we can come up with a common interface: > -- for tab w/ cursor > scrolling happens on every n*Y cursor position, because cursor step is 1. > > -- for tab w/o cursor > scroling happens every cursor step (which is Y in this case). > > Schematically, what we need is a common method which will tell the number > of lines particular tab is going to print, flag that indecates cursor step > and common method (similar to one that used in tuning tab) to print tab > content from BEGIN position to END (BEGIN and END depends on current frame). > > > -ss I just sent a patch attachment as "PowerTOP UI navigation enhancement". Check it out??? Sorry for the slow response. -Chris