From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48303 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757737Ab2IKSim (ORCPT ); Tue, 11 Sep 2012 14:38:42 -0400 Message-ID: <504F851B.5040600@redhat.com> Date: Tue, 11 Sep 2012 15:38:19 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Antti Palosaari CC: linux-media@vger.kernel.org, Hin-Tak Leung Subject: Re: [PATCH 6/6] DVB API: LNA documentation References: <1345167310-8738-1-git-send-email-crope@iki.fi> <1345167310-8738-7-git-send-email-crope@iki.fi> In-Reply-To: <1345167310-8738-7-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 16-08-2012 22:35, Antti Palosaari escreveu: > Signed-off-by: Antti Palosaari > --- > Documentation/DocBook/media/dvb/dvbproperty.xml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml > index d188be9..2dfa6a0 100644 > --- a/Documentation/DocBook/media/dvb/dvbproperty.xml > +++ b/Documentation/DocBook/media/dvb/dvbproperty.xml > @@ -827,6 +827,17 @@ enum fe_interleaving { > }; > > > +
> + <constant>DTV_LNA</constant> > + Low-noise amplifier. > + Hardware might offer controllable LNA which can be set manually > + using that parameter. Usually LNA could be found only from > + terrestrial devices if at all. > + Possible values: 0, 1, INT_MIN Hmm... INT_MIN... are you sure it is portable on all Linux compilers? I don't like the idea on trusting on whatever C/C++/Java/... compiler (or some interpreter) would define as "INT_MIN". The better is to define a value for that, or, instead, to define something at the API header file that won't cause troubles with 32 bits or 64 bits userspace, like defining it as: #define DVB_AUTO_LNA ((u32)~0) > + 0, LNA off > + 1, LNA on > + INT_MIN, LNA auto > +
> >
> Properties used on terrestrial delivery systems > @@ -847,6 +858,7 @@ enum fe_interleaving { > DTV_GUARD_INTERVAL > DTV_TRANSMISSION_MODE > DTV_HIERARCHY > + DTV_LNA > >
>
> @@ -870,6 +882,7 @@ enum fe_interleaving { > DTV_TRANSMISSION_MODE > DTV_HIERARCHY > DTV_DVBT2_PLP_ID > + DTV_LNA > >
>
> @@ -981,6 +994,7 @@ enum fe_interleaving { > DTV_GUARD_INTERVAL > DTV_TRANSMISSION_MODE > DTV_INTERLEAVING > + DTV_LNA > >
> > @@ -1001,6 +1015,7 @@ enum fe_interleaving { > DTV_INVERSION > DTV_SYMBOL_RATE > DTV_INNER_FEC > + DTV_LNA > > >
> @@ -1015,6 +1030,7 @@ enum fe_interleaving { > DTV_FREQUENCY > DTV_MODULATION > DTV_INVERSION > + DTV_LNA > >
> >