From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBW0g-0001Yp-3c for qemu-devel@nongnu.org; Tue, 11 Sep 2012 15:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBW0f-00071h-9E for qemu-devel@nongnu.org; Tue, 11 Sep 2012 15:20:34 -0400 Message-ID: <504F8B6F.3040608@freescale.com> Date: Tue, 11 Sep 2012 14:05:19 -0500 From: Scott Wood MIME-Version: 1.0 References: <1344948607-23291-1-git-send-email-Bharat.Bhushan@freescale.com> <502AFB70.2070101@freescale.com> <6A3DF150A5B70D4F9B66A25E3F7C888D06453361@039-SN2MPN1-022.039d.mgd.msft.net> <50492EA9.3050605@freescale.com> <504A43EC.6030004@freescale.com> <504F217C.80408@suse.de> In-Reply-To: <504F217C.80408@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Wood Scott-B07421 , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Bhushan Bharat-R65777 On 09/11/2012 06:33 AM, Alexander Graf wrote: > On 09/07/2012 08:58 PM, Scott Wood wrote: >> I wasn't suggesting that they be different devices. I was suggesting >> that this isn't a property of the PCI controller, but rather of some >> other entity to which the PCI controller connects. So maybe a reference >> to the associated CCSR object would be a qdev parameter, but not the >> size of that CCSR. > > The first common place of information we get is the machine description. > So here we can do: > > create_device(e500_ccsr, CCSR_SIZE); > create_device(e500_pci_host_controller, CCSR_SIZE); > > Obviously code-wise this would look quite different from above, as > object constructor parameters go through qdev properties. Keep in mind that in order to make MSIs work we need the BAR to actually be hooked up to CCSR, not just sized properly. If qdev properties are really stable API as you indicated recently, we want to get this right and not introduce a short-term hack. -Scott