From mboxrd@z Thu Jan 1 00:00:00 1970 From: juhosg@openwrt.org (Gabor Juhos) Date: Tue, 11 Sep 2012 21:35:45 +0200 Subject: [PATCH 1/3] gpio: 74x164: Add support for the daisy-chaining In-Reply-To: References: <1347309341-15447-1-git-send-email-maxime.ripard@free-electrons.com> <1347309341-15447-2-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <504F9291.9060609@openwrt.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2012.09.11. 19:05 keltez?ssel, Linus Walleij ?rta: > On Mon, Sep 10, 2012 at 10:35 PM, Maxime Ripard > wrote: > >> The shift registers have an output pin that, when enabled, propagates >> the values of its internal register to the pins. If another value comes >> to the register while the output pin is disabled, this new value will >> makae the older shift into the next register in the chain. >> >> This patch adds support for daisy-chaining the registers, using the >> regular SPI chip select mechanism to manage the output pin, and the >> registers-number dt property to set the number of chained registers. >> >> Signed-off-by: Maxime Ripard > > OK cool, but I just realized that this driver was added just two > years ago by Gabor and Miguel, so I'd like to get their feedback > before continuing. > > I know I already merged the DT support and stuff, but better > late than never. > > Please include them on future postings of patches to this > driver... (See To: line) > > Miguel, Gabor: please look at this, I hope you can get hold > of the patches. Please also check the stuff I've already merged > here: > http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=shortlog;h=refs/heads/devel The merged patches look good in general. The merged patches look good in general. However I don't know anything about the 74x164 chip. The driver contain my copyright only because it was based on another driver which I wrote for a different chip. -Gabor