Re: [Qemu-devel] [PATCH 1/5] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved

[Don Slutz <Don@CloudSwitch.Com>]

On 09/06/12 16:05, Eduardo Habkost wrote:
> Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of
> CPUID[1].EDX[10], so do not duplicate it on
> kvm_arch_get_supported_cpuid().
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-By: Igor Mammedov <imammedo@redhat.com>
> ---
>   target-i386/kvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index ffc294e..294af5f 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -164,7 +164,7 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
>                        * so add missing bits according to the AMD spec:
>                        */
>                       cpuid_1_edx = kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
> -                    ret |= cpuid_1_edx & 0x183f7ff;
> +                    ret |= cpuid_1_edx & 0x183f3ff;
>                       break;
>                   }
>                   break;
Reviewed-by: Don Slutz <Don@CloudSwitch.com>