From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TBfnz-0007UT-Pu
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 01:48:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TBfny-0000P2-IQ
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 01:48:07 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:33793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TBfny-0000ON-Az
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 01:48:06 -0400
Message-ID: <5050220C.1000407@msgid.tls.msk.ru>
Date: Wed, 12 Sep 2012 09:47:56 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1347389878-15136-1-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1347389878-15136-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: usbredir fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 11.09.2012 22:57, Aurelien Jarno wrote:
> usbredir is only used by system emulation, so add the libraries to
> libs_softmmu instead of LIBS.

Fwiw, original code breaks user-static build - not it only
tries to link with unused library but also some distros
does not package/provide static (.a) library for
libusbredirparser (I dunno if it is a general issue).

This patch fixes that.  It has been in Debian as a bugfix
since the time usbredir were introduced.

> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 7656c32..cf2621a 100755
> --- a/configure
> +++ b/configure
> @@ -2763,7 +2763,7 @@ if test "$usb_redir" != "no" ; then
>          usb_redir_cflags=$($pkg_config --cflags libusbredirparser 2>/dev/null)
>          usb_redir_libs=$($pkg_config --libs libusbredirparser 2>/dev/null)
>          QEMU_CFLAGS="$QEMU_CFLAGS $usb_redir_cflags"
> -        LIBS="$LIBS $usb_redir_libs"
> +        libs_softmmu="$LIBS $usb_redir_libs"
>      else
>          if test "$usb_redir" = "yes"; then
>              feature_not_found "usb-redir"