From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TBpH0-0000L1-AD
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:54:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TBpGu-0007tz-KN
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:54:42 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58606 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TBpGu-0007tp-Dt
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:54:36 -0400
Message-ID: <5050B039.9060908@suse.de>
Date: Wed, 12 Sep 2012 17:54:33 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<1347224784-19472-6-git-send-email-rth@twiddle.net>
	<50508D38.1050101@suse.de> <5050A63A.7070707@twiddle.net>
In-Reply-To: <5050A63A.7070707@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 09/12/2012 05:11 PM, Richard Henderson wrote:
> On 09/12/2012 06:25 AM, Alexander Graf wrote:
>>> +    case S390_PSWM_REGNUM:
>>> +        env->psw.mask = tmpl;
>>> +        env->cc_op = (tmpl >> 13) & 3;
>> Are you sure this is correct? I thought gdbstub would just ignore the cc bits.
> Well... no it won't ignore the cc bits.

So the CC pseudo-register is never written to?

>   But it would appear that I've got
> them at the wrong location.  From gdb/s390-tdep.c:
>
>    if (regnum == tdep->cc_regnum)
>      {
>        enum register_status status;
>
>        status = regcache_raw_read_unsigned (regcache, S390_PSWM_REGNUM, &val);
>        if (status == REG_VALID)
>          {
>            if (register_size (gdbarch, S390_PSWA_REGNUM) == 4)
>              val = (val >> 12) & 3;

Oops :)


Alex